set vcenter field mutable

[naitianliu-google]

Release Note Template for Downstream PRs (will be copied)

gkeonprem: `vcenter` fields made mutable in `google_gkeonprem_vmware_cluster`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 49 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 4 files changed, 243 insertions(+), 89 deletions(-))
TF Conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3035
Passed tests 2736
Skipped tests: 297
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[NickElliot]

Hello! Do you have a log you can share of the update test passing? That particular test does not run in the CI pipeline due to issues with VCR. I can run it locally if you are somehow unable to.

[naitianliu-google]

Hello! Do you have a log you can share of the update test passing? That particular test does not run in the CI pipeline due to issues with VCR. I can run it locally if you are somehow unable to.

Thanks for checking! Here is the log for the update test. Please let me know if any other information or action is needed.

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta/services/gkeonprem -v -run=TestAccGkeonpremVmwareCluster -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterBasicExample
=== PAUSE TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterBasicExample
=== RUN   TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample
=== PAUSE TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample
=== RUN   TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample
=== PAUSE TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample
=== RUN   TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic
=== PAUSE TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic
=== RUN   TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb
=== PAUSE TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb
=== RUN   TestAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLb
=== PAUSE TestAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLb
=== CONT  TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterBasicExample
=== CONT  TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic
=== CONT  TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample
=== CONT  TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample
=== CONT  TestAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLb
=== CONT  TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb
--- PASS: TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterBasicExample (15.70s)
--- PASS: TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample (15.76s)
--- PASS: TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample (15.77s)
--- PASS: TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic (24.74s)
--- PASS: TestAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLb (25.77s)
--- PASS: TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb (25.98s)
PASS
ok      github.com/hashicorp/terraform-provider-google-beta/google-beta/services/gkeonprem     26.461s

[naitianliu-google]

@NickElliot Friendly ping. Please help take a look when you get a chance. Thanks!

[NickElliot]

LGTM!