Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump EdgeCacheOrigin timeout + add reference docs #8960

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

rileykarson
Copy link
Member

Took 81m to fail in a test.

Release Note Template for Downstream PRs (will be copied)

networkservices: increased default timeout for `google_network_services_edge_cache_origin` to 120m from 60m

@rileykarson rileykarson requested review from a team and zli82016 and removed request for a team September 14, 2023 20:51
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3044
Passed tests 2746
Skipped tests: 298
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants