Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove container network policy provider default #8965

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 15, 2023

fixes hashicorp/terraform-provider-google#11244
upgrade guide: #8968

Release Note Template for Downstream PRs (will be copied)

container: removed default value in `network_policy.provider` in `google_container_cluster`

@c2thorn c2thorn changed the base branch from main to FEATURE-BRANCH-major-release-5.0.0 September 15, 2023 05:33
@c2thorn c2thorn changed the title 5.0.0 container network default remove container network policy provider default Sep 15, 2023
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@c2thorn c2thorn force-pushed the 5.0.0-container-network-default branch from 380122c to 126ec96 Compare September 20, 2023 08:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field network_policy.provider default value changed from PROVIDER_UNSPECIFIED to on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2729
Skipped tests: 304
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMemcacheInstance_memcacheInstanceBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested review from a team and hao-nan-li and removed request for a team September 20, 2023 16:10
@c2thorn
Copy link
Member Author

c2thorn commented Sep 20, 2023

I don't believe TestAccVertexAIIndexEndpoint_updated failure is related

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I also don't think TestAccVertexAIIndexEndpoint_updated is related to the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster.network_policy.provider PROVIDER_UNSPECIFIED is invalid network policy provider
3 participants