Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to ONLY_SCALE_OUT #8984

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Sep 18, 2023

Fixes hashicorp/terraform-provider-google#15879

Release Note Template for Downstream PRs (will be copied)

compute: updated the `autoscaling_policy.mode` to accept `ONLY_SCALE_OUT` on `google_compute_autoscaler` 

@edwardmedia
Copy link
Contributor Author

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3062
Passed tests 2763
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 8 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 4 files changed, 8 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3065
Passed tests 2766
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you change the changelog?

@edwardmedia edwardmedia merged commit 29e330b into GoogleCloudPlatform:main Sep 18, 2023
15 checks passed
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
* updated to ONLY_SCALE_OUT

* change the data type to string

---------

Co-authored-by: Edward Sun <sunedward@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GCE Autoscaler expected values to be in line with UI, gcloud, API.
3 participants