Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tpg-test to go #8992

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Migrate tpg-test to go #8992

merged 1 commit into from
Sep 21, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Sep 18, 2023

Release Note Template for Downstream PRs (will be copied)


@trodge trodge force-pushed the tpg-test-go branch 2 times, most recently from db14b33 to d1b4dc0 Compare September 19, 2023 00:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge requested a review from ScottSuarez September 19, 2023 19:21
@ScottSuarez
Copy link
Contributor

Were the unit tests kicked off? I don't see it posting to this PR

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 5 deletions(-))

@trodge trodge force-pushed the tpg-test-go branch 2 times, most recently from 72253e1 to 6662c93 Compare September 19, 2023 21:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge force-pushed the tpg-test-go branch 2 times, most recently from 18dbe79 to 9bf4ed1 Compare September 19, 2023 21:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Contributor

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3075
Passed tests 2773
Skipped tests: 300
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge merged commit bc48ba2 into GoogleCloudPlatform:main Sep 21, 2023
@trodge trodge deleted the tpg-test-go branch September 21, 2023 17:44
c2thorn pushed a commit that referenced this pull request Sep 21, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
melinath added a commit to melinath/magic-modules that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants