Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instance.yaml to remove LOOKER_MODELER edition #9033

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Update Instance.yaml to remove LOOKER_MODELER edition #9033

merged 1 commit into from
Sep 22, 2023

Conversation

efeelaiho
Copy link
Contributor

@efeelaiho efeelaiho commented Sep 20, 2023

fixes hashicorp/terraform-provider-google#15923

Release Note Template for Downstream PRs (will be copied)

looker: removed `LOOKER_MODELER` as a possible value in `google_looker_instance. platform_edition`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented Sep 20, 2023

Is there a GH issue and upgrade guide associated with this PR?

@efeelaiho
Copy link
Contributor Author

@c2thorn No, this is an internal issue to remove LOOKER_MODELER edition as we will not be GA'ing that offering. b/301270835
b/298254910

@c2thorn
Copy link
Member

c2thorn commented Sep 20, 2023

created hashicorp/terraform-provider-google#15923 to track and updated the changelog. We require an upgrade guide entry for breaking changes to explain what users should use instead. This will need to be in a separate pull request to the main branch. Instructions are at https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#add-upgrade-guide-entries-to-the-main-branch-of-magic-modules

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3068
Passed tests 2759
Skipped tests: 307
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Sep 22, 2023

created hashicorp/terraform-provider-google#15923 to track and updated the changelog. We require an upgrade guide entry for breaking changes to explain what users should use instead. This will need to be in a separate pull request to the main branch. Instructions are at googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#add-upgrade-guide-entries-to-the-main-branch-of-magic-modules

@efeelaiho have you seen this?

@efeelaiho
Copy link
Contributor Author

@c2thorn Thanks! Have created this PR: #9052
for the upgrade guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants