Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change contributor checker merge to upstream from origin #9042

Merged

Conversation

ScottSuarez
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez changed the title check remotes in cloud build change contributor checker merge to upstream from origin Sep 21, 2023
@ScottSuarez ScottSuarez merged commit 7e712d2 into GoogleCloudPlatform:main Sep 21, 2023
@ScottSuarez ScottSuarez deleted the check-remotes-in-cloudbuild branch September 21, 2023 21:41
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
drcapulet added a commit to drcapulet/magic-modules that referenced this pull request Dec 6, 2023
It's a bit counterintuitive that creating a per-instance config in an IGM
spins up an instance but destroying it leaves the instance behind.

Also fixed a bug related to the operation to detach the disk from the
instance failing due to the instance having been deleted.

Fixes GoogleCloudPlatform#9042 & #16621.
drcapulet added a commit to drcapulet/magic-modules that referenced this pull request Dec 6, 2023
…resources.

It's a bit counterintuitive that creating a per-instance config in an IGM
spins up an instance but destroying it leaves the instance behind.

Also fixed a bug related to the operation to detach the disk from the
instance failing due to the instance having been deleted.

Fixes GoogleCloudPlatform#9042 & #16621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants