-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve autoscaling_policy support in google_compute_node_group #9044
improve autoscaling_policy support in google_compute_node_group #9044
Conversation
There was an issue with contributor-membership-checker fixed yesterday, rebasing should fix @NickElliot |
c390e14
to
4134a1a
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 227 insertions(+), 63 deletions(-)) |
6374511
to
83df041
Compare
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_withSoleTenantConfig|TestAccDataprocCluster_withNodeGroupAffinity|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 230 insertions(+), 66 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 229 insertions(+), 66 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNodeGroup_fail|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_update|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccDataprocCluster_withNodeGroupAffinity |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
bd254c8
to
e923d8d
Compare
Remaining tests referencing size over initial_size fixed, other test failures unrelated |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccDataprocCluster_withNodeGroupAffinity |
|
Well, resource is working, theres just either a sweeper problem or quota problem, or too many tests are happening at once in the project 🙃 |
think CPU quota is no longer exceeded, going to rerun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests (hopefully we can get passing cassettes in)
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withSandboxConfig|TestAccDataprocCluster_withNodeGroupAffinity |
Rerun these tests in REPLAYING mode to catch issues
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccDataprocCluster_withNodeGroupAffinity |
Rerun these tests in REPLAYING mode to catch issues
|
One more try? |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocCluster_withNodeGroupAffinity |
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocCluster_withNodeGroupAffinity |
|
e19357f
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Fixes hashicorp/terraform-provider-google#13928
node_group
is now mutableinital_size
orautoscaling_policy
must be configured on resource creationRelease Note Template for Downstream PRs (will be copied)