Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote OS repositories to Artifact Registry #9047

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

juliocc
Copy link
Contributor

@juliocc juliocc commented Sep 22, 2023

This PR adds support for remote APT and YUM repositories to Artifact Registry.

Fixes hashicorp/terraform-provider-google#15703

Release Note Template for Downstream PRs (will be copied)

artifactregistry: added support for remote APT and YUM repositories to `google_artifact_registry_repository` 

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 4 files changed, 117 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_artifact_registry_repository (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_artifact_registry_repository" "primary" {
  remote_repository_config {
    yum_repository {
      public_repository {
        repository_base = # value needed
        repository_path = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3079
Passed tests 2777
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Sep 22, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 120 insertions(+))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3079
Passed tests 2780
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_artifact_registry_repository - Support remote repositories for OS packages
3 participants