-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remote OS repositories to Artifact Registry #9047
Conversation
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
51cdf76
to
d5ea055
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_artifact_registry_repository" "primary" {
remote_repository_config {
yum_repository {
public_repository {
repository_base = # value needed
repository_path = # value needed
}
}
}
}
|
d5ea055
to
25101b6
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 464 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests:
|
This PR adds support for remote APT and YUM repositories to Artifact Registry.
Fixes hashicorp/terraform-provider-google#15703
Release Note Template for Downstream PRs (will be copied)