Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to provider fields in both SDK and PF implementations of provider schema #9050

Merged
merged 10 commits into from
Sep 23, 2023
Merged

Add validation to provider fields in both SDK and PF implementations of provider schema #9050

merged 10 commits into from
Sep 23, 2023

Commits on Sep 22, 2023

  1. Add empty-string validator for PF provider

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b7090c2 View commit details
    Browse the repository at this point in the history

  2. Add empty-string validator for SDK provider, move SDK validators to s… 

    …eparate file
    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e095caa View commit details
    Browse the repository at this point in the history

  3. Add empty string validators to : credentials, access_token, impersona… 

    …te_service_account, project, billing_project, region, zone
    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    267db29 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for ValidateEmptyStrings

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    aac6d2f View commit details
    Browse the repository at this point in the history

  5. Remove empty string test case from ValidateCredentials

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3886618 View commit details
    Browse the repository at this point in the history

  6. Add acceptace tests showing that empty strings in provider block resu… 

    …lts in a validation error, and empty provider blocks have no validation errors
    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    91ba0f1 View commit details
    Browse the repository at this point in the history

  7. Make the SDK provider's ValidateCredentials validator reject empty … 

    …strings
    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d4ca090 View commit details
    Browse the repository at this point in the history

  8. Update acceptance test after change in credentials validation

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    81be660 View commit details
    Browse the repository at this point in the history

  9. Fix test definitions to avoid fall-through

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    bcb9cad View commit details
    Browse the repository at this point in the history

  10. Update validation error message in code and tests

    @SarahFrench
    SarahFrench committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    34134f0 View commit details
    Browse the repository at this point in the history