-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds device name parameter to scratch disk #9069
Adds device name parameter to scratch disk #9069
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 65 insertions(+), 6 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance_from_template" "primary" {
scratch_disk {
device_name = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_with375GbScratchDisk |
Rerun these tests in REPLAYING mode to catch issues
|
a5efa3a
to
5488a35
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 73 insertions(+), 7 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance_from_template" "primary" {
scratch_disk {
device_name = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccComputeInstanceTemplate_withScratchDisk|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 123 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout|TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout|TestAccContainerCluster_withAddons |
Rerun these tests in REPLAYING mode to catch issues
|
device_name
parameter to thescratch_disk
block of the resourcegoogle_compute_instance
Release Note Template for Downstream PRs (will be copied)