add support for min_num_instances in google_dataproc_cluster

[sunchengxuanivy]

Release Note Template for Downstream PRs (will be copied)

dataproc: added `min_num_instances` field to `google_dataproc_cluster` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rileykarson]

Rather than just guard on the value being nonzero, we should pass through the type of config we're checking and write the value conditionally. If the API began to allow a minimum number of primary instances and started passing through a value to a user (a backwards compatible change), the user would get an error on their next Terraform run as we tried to write to a value that didn't exist.

[rileykarson]

nit: Do you mind spacing these lines as two spaces rather than tabs, for consistency within the config?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 84 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 84 insertions(+), 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3120
Passed tests 2798
Skipped tests: 315
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withAddons|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccDataprocCluster_withMinNumInstances|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccDataprocCluster_withMinNumInstances[Error message] [Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Generating to run tests- will make a full review pass tomorrow.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 734 insertions(+), 140 deletions(-))
Terraform Beta: Diff ( 4 files changed, 734 insertions(+), 140 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3147
Passed tests 2827
Skipped tests: 316
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccBigQueryDataTable_bigtable|TestAccDataprocCluster_withMinNumInstances

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataprocCluster_withMinNumInstances[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

LGTM, thanks! Especially for going ahead and splitting those out 🎉