dataform_repository - add missing args

[DrFaust92]

Closes hashicorp/terraform-provider-google#15975

Release Note Template for Downstream PRs (will be copied)

dataform: added `display_name`, `labels` and `npmrc_environment_variables_secret_version` fields to `google_dataform_repository` resource 

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 107 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 477 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 98 insertions(+))
TF OiCS: Diff ( 4 files changed, 147 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataform_repository (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataform_repository" "primary" {
  service_account              = # value needed
  set_authenticated_user_admin = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3121
Passed tests 2798
Skipped tests: 318
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDataformRepository_dataformRepositoryFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccDataformRepository_dataformRepositoryFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 42 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 217 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 47 insertions(+))
TF OiCS: Diff ( 1 file changed, 7 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3162
Passed tests 2843
Skipped tests: 318
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformRepository_dataformRepositoryExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataformRepository_dataformRepositoryExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

Sorry I somehow missed this from my review list.

This test failed with error:

 Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # google_dataform_repository.dataform_respository must be replaced
        -/+ resource "google_dataform_repository" "dataform_respository" {
              ~ id                                         = "projects/ci-test-project-188019/locations/us-central1/repositories/tf_test_dataform_repository76o4gxbo8z" -> (known after apply)
                name                                       = "tf_test_dataform_repository76o4gxbo8z"
              ~ set_authenticated_user_admin               = false -> true # forces replacement
                # (6 unchanged attributes hidden)
        
              ~ git_remote_settings {
                  + token_status                        = (known after apply)
                    # (3 unchanged attributes hidden)
                }
        
                # (1 unchanged block hidden)
            }

Are you able to get the test passed locally? It could be that the API does not return this field at all

[DrFaust92]

Thanks, will check there was a big rebase after initial test

…

On Wed, 1 Nov 2023 at 20:59 Shuya Ma ***@***.***> wrote: ***@***.**** commented on this pull request. Sorry I somehow missed this from my review list. This test failed with error: Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # google_dataform_repository.dataform_respository must be replaced -/+ resource "google_dataform_repository" "dataform_respository" { ~ id = "projects/ci-test-project-188019/locations/us-central1/repositories/tf_test_dataform_repository76o4gxbo8z" -> (known after apply) name = "tf_test_dataform_repository76o4gxbo8z" ~ set_authenticated_user_admin = false -> true # forces replacement # (6 unchanged attributes hidden) ~ git_remote_settings { + token_status = (known after apply) # (3 unchanged attributes hidden) } # (1 unchanged block hidden) } Are you able to get the test passed locally? It could be that the API does not return this field at all — Reply to this email directly, view it on GitHub <#9173 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7XJ2WXZMRUNPUM2MHTYCKLYLAVCNFSM6AAAAAA5UD6XRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBYHA2DGOBSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 31 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 216 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 37 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3260
Passed tests 2924
Skipped tests: 332
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformRepository_dataformRepositoryExample|TestAccDataformRepositoryIamBindingGenerated|TestAccDataformRepositoryIamMemberGenerated|TestAccDataformRepositoryIamPolicyGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataformRepository_dataformRepositoryExample[Debug log]
TestAccDataformRepositoryIamBindingGenerated[Debug log]
TestAccDataformRepositoryIamMemberGenerated[Debug log]
TestAccDataformRepositoryIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shuyama1]

LGTM! Only one small comment. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 29 insertions(+))
Terraform Beta: Diff ( 4 files changed, 214 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 37 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3268
Passed tests 2934
Skipped tests: 334
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[shuyama1]

Thank you!