Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enforce mutual exclusivity among view, materialized view, and… #9204

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Oct 9, 2023

… schema in BigQuery table config (#7973)"

This reverts commit 87e4f29.

Fixes https://github.com/hashicorp/terraform-provider-google/issues/16134.

Release Note Template for Downstream PRs (will be copied)

bigquery: removed mutual exclusivity checks for view, materialized view, and schema for the Table resource.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn c2thorn requested review from c2thorn and removed request for NickElliot October 9, 2023 21:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 48 insertions(+), 129 deletions(-))
Terraform Beta: Diff ( 2 files changed, 48 insertions(+), 129 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 48 insertions(+), 157 deletions(-))
Terraform Beta: Diff ( 2 files changed, 48 insertions(+), 157 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3131
Passed tests 2813
Skipped tests: 316
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants