promote gkeonprem resources to GA

[naitianliu-google]

Release Note Template for Downstream PRs (will be copied)

gkeonprem: promoted `google_gkeonprem_bare_metal_admin_cluster`, `google_gkeonprem_bare_metal_cluster`, and `google_gkeonprem_bare_metal_node_pool` resources to GA

gkeonprem: promoted `google_gkeonprem_vmware_cluster` and `google_gkeonprem_vmware_node_pool` resources to GA

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 29 files changed, 16681 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 14 files changed, 12 insertions(+), 88 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3141
Passed tests 2817
Skipped tests: 316
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGkeonpremBareMetalNodePool_bareMetalNodePoolUpdate|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateManualLb|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBgpLb|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic|TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb|TestAccGkeonpremVmwareNodePool_vmwareNodePoolUpdate|TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGkeonpremBareMetalNodePool_bareMetalNodePoolUpdate[Error message] [Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateManualLb[Error message] [Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBgpLb[Error message] [Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic[Error message] [Debug log]
TestAccGkeonpremVmwareCluster_vmwareClusterUpdateF5Lb[Error message] [Debug log]
TestAccGkeonpremVmwareNodePool_vmwareNodePoolUpdate[Error message] [Debug log]
TestAccGkeonpremVmwareCluster_vmwareClusterUpdateBasic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[roaks3]

@naitianliu-google it looks like you'll also need to change occurrences of ProtoV5ProviderBetaFactories with ProtoV5ProviderFactories. I believe that is what is causing the test failures.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 29 files changed, 16681 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 14 files changed, 20 insertions(+), 96 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3144
Passed tests 2826
Skipped tests: 316
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_cloudRunServiceSqlExample|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunService_cloudRunServiceSqlExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[roaks3]

LGTM, test failure is unrelated. I also tweak the release note.