-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional_group_keys
attribute to google_cloud_identity_group
resource
#9217
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had to questions, but overall seems fairly straight-forward
mmv1/third_party/terraform/services/cloudidentity/resource_cloud_identity_group_test.go.erb
Show resolved
Hide resolved
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_clientConnectionConfig|TestAccBigQueryDataTable_bigtable|TestAccCloudRunService_cloudRunServiceSqlExample |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wanted to note that we may want to add a fixes: X
line if this fixes an issue
Thanks for the review! |
Tangentially related to (hashicorp/terraform-provider-google#15812) - this PR exposes the 'additional group keys' of a group which could be used to find a Group via the Lookup API mentioned there.
Release Note Template for Downstream PRs (will be copied)