Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional_group_keys attribute to google_cloud_identity_group resource #9217

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Oct 10, 2023

Tangentially related to (hashicorp/terraform-provider-google#15812) - this PR exposes the 'additional group keys' of a group which could be used to find a Group via the Lookup API mentioned there.

Release Note Template for Downstream PRs (will be copied)

cloudidentity: Added `additional_group_keys` attribute to `google_cloud_identity_group` resource

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 93 insertions(+))
Terraform Beta: Diff ( 3 files changed, 93 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3144
Passed tests 2824
Skipped tests: 316
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench requested a review from roaks3 October 11, 2023 16:38
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had to questions, but overall seems fairly straight-forward

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 92 insertions(+))
Terraform Beta: Diff ( 3 files changed, 92 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3145
Passed tests 2826
Skipped tests: 316
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbInstance_clientConnectionConfig|TestAccBigQueryDataTable_bigtable|TestAccCloudRunService_cloudRunServiceSqlExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wanted to note that we may want to add a fixes: X line if this fixes an issue

@SarahFrench
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants