Adding support for Autoclass 2.1

[thomasmaclean]

Adds the terminal_storage_class field to autoclass configurations for google_storage_bucket.

Release Note Template for Downstream PRs (will be copied)

storage: added `terminal_storage_class` to the `autoclass` field in `google_storage_bucket` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 45 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 45 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (388 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  autoclass {
    terminal_storage_class = # value needed
  }
}

[thomasmaclean]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 45 insertions(+), 7 deletions(-)) Terraform Beta: Diff ( 2 files changed, 45 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (388 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  autoclass {
    terminal_storage_class = # value needed
  }
}

There are tests for the new field, but the detection seems to have failed (If I had to guess it's because the tests include the test configs includes a space between autoclass and the opening bracket (i.e. autoclass {).

[modular-magician]

Tests analytics

Total tests: 3142
Passed tests 2823
Skipped tests: 318
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageBucket_basicWithAutoclass

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageBucket_basicWithAutoclass[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (388 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  autoclass {
    terminal_storage_class = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3144
Passed tests 2823
Skipped tests: 318
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccDataprocJobIamPolicy|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

This seems straightforward; I just have a couple questions.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 45 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 45 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_bucket (388 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_bucket" "primary" {
  autoclass {
    terminal_storage_class = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3148
Passed tests 2830
Skipped tests: 317
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageBucket_basicWithAutoclass

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageBucket_basicWithAutoclass[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test