Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set labels and annotations fields in cloudrunv2 data sources #9301

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 18, 2023

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: set fields `labels` and `terraform_labels` having all of labels present on the resource in GCP in data source `google_cloud_run_v2_service`
cloudrunv2: set field `annotations` having all of annotations present on the resource in GCP in data source `google_cloud_run_v2_service`
cloudrunv2: set fields `labels` and `terraform_labels` having all of labels present on the resource in GCP in data source `google_cloud_run_v2_job`
cloudrunv2: set field `annotations` having all of annotations present on the resource in GCP in data source `google_cloud_run_v2_job`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 32 insertions(+))
Terraform Beta: Diff ( 4 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3153
Passed tests 2833
Skipped tests: 318
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleCloudRunV2Service_basic|TestAccDataSourceGoogleCloudRunV2Job_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleCloudRunV2Service_basic[Debug log]
TestAccDataSourceGoogleCloudRunV2Job_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member Author

Is it a breaking change to change the value of fields for data source?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are reasonably bugfixes given the new model on the resource and the model applied to other datasources- this was just an unintentional regression.

Other kinds of changes- such as changing the format of a field- would be though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants