Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing pingsCount, userLabels, and customContentType fields #9388

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jdurelli
Copy link
Contributor

@jdurelli jdurelli commented Nov 1, 2023

Add fields present in the Uptime Check API that were missing from the corresponding terraform files.

Fixes hashicorp/terraform-provider-google#13001
Fixes hashicorp/terraform-provider-google#14285
Fixes hashicorp/terraform-provider-google#14724

monitoring: added `pings_count`, `user_labels`, and `custom_content_type` fields to `google_monitoring_uptime_check_config` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 1, 2023
@jdurelli jdurelli marked this pull request as ready for review November 1, 2023 13:46
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 1, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 266 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 266 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 88 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_uptime_check_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_uptime_check_config" "primary" {
  http_check {
    ping_config {
      pings_count = # value needed
    }
  }
}

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 1, 2023
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3195
Passed tests 2867
Skipped tests: 325
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample|TestAccMonitoringUptimeCheckConfig_uptimeCheckTcpExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 1, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 272 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 272 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 88 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3195
Passed tests 2868
Skipped tests: 325
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample|TestAccMonitoringUptimeCheckConfig_uptimeCheckTcpExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample[Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckTcpExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants