-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing pingsCount, userLabels, and customContentType fields #9388
Adding missing pingsCount, userLabels, and customContentType fields #9388
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
49b7a85
to
bc06c7a
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 266 insertions(+), 5 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_monitoring_uptime_check_config" "primary" {
http_check {
ping_config {
pings_count = # value needed
}
}
}
|
bc06c7a
to
2ac23b8
Compare
2ac23b8
to
30ed4cd
Compare
30ed4cd
to
bc3f034
Compare
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample|TestAccMonitoringUptimeCheckConfig_uptimeCheckTcpExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 272 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample|TestAccMonitoringUptimeCheckConfig_uptimeCheckTcpExample |
Rerun these tests in REPLAYING mode to catch issues
|
Add fields present in the Uptime Check API that were missing from the corresponding terraform files.
Fixes hashicorp/terraform-provider-google#13001
Fixes hashicorp/terraform-provider-google#14285
Fixes hashicorp/terraform-provider-google#14724