-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add instance autoscaling attributes to spanner instance resource #9403
feat(spanner): add instance autoscaling attributes to spanner instance resource #9403
Conversation
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 384 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig |
Rerun these tests in REPLAYING mode to catch issues
|
/gcbrun |
@zli82016 can you please help review this |
The API documentation is not updated to have the new field. Will the API doc be updated soon? |
mmv1/third_party/terraform/services/spanner/resource_spanner_instance_test.go
Show resolved
Hide resolved
Yes its scheduled to be announced in public next week, proto changes and client library changes has already been merged, we need Terraform support before public announcement. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 395 insertions(+), 5 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_spanner_instance" "primary" {
autoscaling_config {
autoscaling_limits {
max_processing_units = # value needed
min_processing_units = # value needed
}
autoscaling_targets {
high_priority_cpu_utilization_percent = # value needed
storage_utilization_percent = # value needed
}
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 395 insertions(+), 5 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_spanner_instance" "primary" {
autoscaling_config {
autoscaling_limits {
max_processing_units = # value needed
min_processing_units = # value needed
}
autoscaling_targets {
high_priority_cpu_utilization_percent = # value needed
storage_utilization_percent = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig |
Rerun these tests in REPLAYING mode to catch issues
|
The test failed. It looks like the new field needs to be added to |
Thanks @zli82016 for pointing me this, have incorporated the changes and added tests. please help review. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 453 insertions(+), 5 deletions(-)) |
Can you please fix the unit tests, @rahul2393 ? Thanks. |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate |
Rerun these tests in REPLAYING mode to catch issues
|
Fixed!! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 453 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. LGTM.
…e resource (GoogleCloudPlatform#9403) * feat(spanner): add instance autoscaling attributed to spanner instance resource * add update tests * fix tests * fix tests * fix lint
…e resource (GoogleCloudPlatform#9403) * feat(spanner): add instance autoscaling attributed to spanner instance resource * add update tests * fix tests * fix tests * fix lint
…e resource (GoogleCloudPlatform#9403) * feat(spanner): add instance autoscaling attributed to spanner instance resource * add update tests * fix tests * fix tests * fix lint
Release Note Template for Downstream PRs (will be copied)