[#16400] Fix and simplify InternalIpDiffSuppress function #9423

LucaPrete · 2023-11-07T14:26:56Z

As per #16400 the PR

fixes the InternalIpDiffSuppress function, which currently generates a drift for net masked IPv6 addresses and non net-masked IPv6 addresses (i.e. fd20:6c7:bb6a:f400:0:0:0:0/96 --> fd20:6c7:bb6a:f400::)
simplifies the InternalIpDiffSuppress function

Fix (and simplify) InternalIpDiffSuppress function to suppress drifts for IPv6 with and without netmask.

modular-magician · 2023-11-07T14:29:05Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

LucaPrete · 2023-11-07T14:32:07Z

cc @rileykarson FYI

modular-magician · 2023-11-07T14:38:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 45 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 45 insertions(+), 13 deletions(-))

modular-magician · 2023-11-07T15:50:12Z

Tests analytics

Total tests: 3206
Passed tests 2855
Skipped tests: 325
Affected tests: 26

Action taken

Found 26 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

modular-magician · 2023-11-07T16:21:42Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeVpnTunnel_defaultTrafficSelectors[Error message] [Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Error message] [Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Error message] [Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Error message] [Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Error message] [Debug log]
TestAccComputeRouterInterface_basic[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_ip[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath

A couple questions below.

I'm also not sure that the tests for non-IP addresses are correct - I believe they should expect a format like projects/project_id/regions/region/addresses/address-name rather than a resource reference (which would get expanded to some other value)

melinath · 2023-11-07T20:00:01Z

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb

+	addr_netmask_new := strings.Split(new, "/")
+
+	// Check if old or new are IPs (with or without netmask)
+	addr_old := func() net.IP {


Why are these being handled in closures? That's not a common pattern in this codebase.

melinath · 2023-11-07T20:01:50Z

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb

+	}
+
+	// If old and new have a netmask compare them,
+	// otherwise always assume they are the same


I'm not super familiar with IPv6 - why is this a safe assumption to make? (A link to documentation explaining this would be great!)

Unfortunately, this is not safe and it's not documented anywhere but it's exactly what we're trying to solve with this patch. Please look at the bug we're referencing (#16400).

mmv1/third_party/terraform/tpgresource/common_diff_suppress_test.go

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb

melinath · 2023-11-07T20:19:14Z

It looks like the unit tests are also currently failing - please make sure unit tests are passing locally before pushing a new commit.

LucaPrete · 2023-11-08T06:48:40Z

Curious thing is…they were passing locally! I’ll look again into it. Thanks Stephen.

…

-Luca Il giorno mar 7 nov 2023 alle 21:19 Stephen Lewis (Burrows) < ***@***.***> ha scritto:

It looks like the unit tests are also currently failing - please make sure unit tests are passing locally before pushing a new commit. — Reply to this email directly, view it on GitHub <#9423 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARY7UBMUXLLK2AYFUKPX4TYDKJU3AVCNFSM6AAAAAA7BI7MISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZHEZDGNZSHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

modular-magician · 2023-11-09T10:31:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 101 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 101 insertions(+), 32 deletions(-))

modular-magician · 2023-11-09T11:43:53Z

Tests analytics

Total tests: 3223
Passed tests 2882
Skipped tests: 328
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

modular-magician · 2023-11-09T11:59:11Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeForwardingRule_ip[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-09T13:06:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 99 insertions(+), 35 deletions(-))
Terraform Beta: Diff ( 2 files changed, 99 insertions(+), 35 deletions(-))

modular-magician · 2023-11-09T14:28:12Z

Tests analytics

Total tests: 3223
Passed tests 2883
Skipped tests: 328
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

modular-magician · 2023-11-09T14:45:01Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Error message] [Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisNoAutomateDnsExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

LucaPrete · 2023-11-09T15:57:46Z

@melinath I really don't understand why I see different results locally:

lucaprete-macbookpro:terraform-provider-google lucaprete$ make testacc TEST=./google/tpgresource TESTARGS='-run=TestOptionalPrefixSuppress'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/tpgresource -v -run=TestOptionalPrefixSuppress -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestOptionalPrefixSuppress
--- PASS: TestOptionalPrefixSuppress (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/tpgresource	1.138s
lucaprete-macbookpro:terraform-provider-google lucaprete$

Any idea please?

melinath

@LucaPrete it looks like you're running TestOptionalPrefixSuppress - but the test that's failing is TestInternalIpDiffSuppress. Any chance that's the issue?

It looks like the failing VCR tests may be related to this change as well, but I'm not exactly sure how. The errors are like:

Error: Error creating ForwardingRule: googleapi: Error 400: Invalid value for field 'resource.IPAddress': ''. No IP address specified for Private Service Connect forwarding rule., invalid

LucaPrete · 2023-11-09T17:04:09Z

TestInternalIpDiffSuppress

Arg, sorry... not sure how I haven't noticed it. I'll fix the tests and get back, hopefully soon.

modular-magician · 2023-11-11T17:54:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 94 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 94 insertions(+), 32 deletions(-))

modular-magician · 2023-11-11T19:07:38Z

Tests analytics

Total tests: 3225
Passed tests 2888
Skipped tests: 329
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_ip|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccDataprocClusterIamPolicy|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

modular-magician · 2023-11-11T19:25:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

LucaPrete · 2023-11-12T13:24:17Z

@melinath replies to all your comments and fixed the code/tests

melinath

LGTM apart from a couple tweaks to comments

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb

modular-magician · 2023-11-14T07:58:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 94 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 94 insertions(+), 32 deletions(-))

modular-magician · 2023-11-14T09:10:52Z

Tests analytics

Total tests: 3225
Passed tests 2896
Skipped tests: 329
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb

LucaPrete · 2023-11-15T09:31:15Z

@melinath done! Thanks for the review

melinath · 2023-11-15T17:20:07Z

@LucaPrete could you make sure the changes are pushed?

LucaPrete · 2023-11-16T07:43:38Z

@LucaPrete could you make sure the changes are pushed?

Now I did. Sorry again.

modular-magician · 2023-11-16T07:55:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 95 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 95 insertions(+), 32 deletions(-))

modular-magician · 2023-11-16T09:16:59Z

Tests analytics

Total tests: 3230
Passed tests 2897
Skipped tests: 330
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-11-16T09:27:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

melinath

Thanks! LGTM

…dPlatform#9423) * [#16400] Fix and simplify InternalIpDiffSuppress function * Fixes as per PR comments * Adding new tests for different netmasks * fix test * Fixes to unit tests * Fixes per comments * Comments fixes --------- Co-authored-by: Luca Prete <lucaprete@google.com>

modular-magician requested a review from melinath November 7, 2023 14:29

melinath requested changes Nov 7, 2023

View reviewed changes

modular-magician requested a review from melinath November 9, 2023 10:18

melinath requested changes Nov 9, 2023

View reviewed changes

modular-magician requested a review from melinath November 11, 2023 17:45

melinath requested changes Nov 13, 2023

View reviewed changes

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb Outdated Show resolved Hide resolved

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb Outdated Show resolved Hide resolved

Luca Prete added 5 commits November 14, 2023 08:46

[#16400] Fix and simplify InternalIpDiffSuppress function

61e8bdc

Fixes as per PR comments

7bf70f3

Adding new tests for different netmasks

598b58b

fix test

eb6d876

Fixes to unit tests

de9b424

Fixes per comments

8a69de3

LucaPrete requested a review from melinath November 14, 2023 07:47

LucaPrete force-pushed the fix_ip_suppress_func branch from d75d147 to 8a69de3 Compare November 14, 2023 07:47

melinath requested changes Nov 14, 2023

View reviewed changes

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb Outdated Show resolved Hide resolved

mmv1/third_party/terraform/tpgresource/common_diff_suppress.go.erb Show resolved Hide resolved

Comments fixes

f49f3d0

LucaPrete requested a review from melinath November 16, 2023 07:43

melinath approved these changes Nov 16, 2023

View reviewed changes

melinath merged commit 06aa6a6 into GoogleCloudPlatform:main Nov 16, 2023
12 checks passed

This was referenced Nov 16, 2023

[#16400] Fix and simplify InternalIpDiffSuppress function hashicorp/terraform-provider-google-beta#6652

Merged

[#16400] Fix and simplify InternalIpDiffSuppress function hashicorp/terraform-provider-google#16550

Merged

melinath mentioned this pull request Nov 29, 2023

Drift google_compute_forwarding_rule ip_address for IPv6 hashicorp/terraform-provider-google#16400

Closed

[#16400] Fix and simplify InternalIpDiffSuppress function #9423

[#16400] Fix and simplify InternalIpDiffSuppress function #9423

Conversation

LucaPrete commented Nov 7, 2023

modular-magician commented Nov 7, 2023

LucaPrete commented Nov 7, 2023

modular-magician commented Nov 7, 2023

Diff report

modular-magician commented Nov 7, 2023

Tests analytics

Action taken

modular-magician commented Nov 7, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath left a comment

Choose a reason for hiding this comment

melinath Nov 7, 2023

Choose a reason for hiding this comment

LucaPrete Nov 9, 2023

Choose a reason for hiding this comment

melinath Nov 7, 2023

Choose a reason for hiding this comment

LucaPrete Nov 9, 2023

Choose a reason for hiding this comment

melinath commented Nov 7, 2023

LucaPrete commented Nov 8, 2023 via email

modular-magician commented Nov 9, 2023

Diff report

modular-magician commented Nov 9, 2023

Tests analytics

Action taken

modular-magician commented Nov 9, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 9, 2023

Diff report

modular-magician commented Nov 9, 2023

Tests analytics

Action taken

modular-magician commented Nov 9, 2023

Rerun these tests in REPLAYING mode to catch issues

LucaPrete commented Nov 9, 2023

melinath left a comment

Choose a reason for hiding this comment

LucaPrete commented Nov 9, 2023

modular-magician commented Nov 11, 2023

Diff report

modular-magician commented Nov 11, 2023

Tests analytics

Action taken

modular-magician commented Nov 11, 2023

Rerun these tests in REPLAYING mode to catch issues

LucaPrete commented Nov 12, 2023

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 14, 2023

Diff report

modular-magician commented Nov 14, 2023

Tests analytics

LucaPrete commented Nov 15, 2023

melinath commented Nov 15, 2023

LucaPrete commented Nov 16, 2023

modular-magician commented Nov 16, 2023

Diff report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath left a comment

Choose a reason for hiding this comment