-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UptimeCheckConfig custom delete for 400s #9429
UptimeCheckConfig custom delete for 400s #9429
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 6 insertions(+), 139 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy|TestAccDataSourceGoogleServiceAccountAccessToken_basic |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/templates/terraform/custom_delete/monitoring_uptime_check_config.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 6 insertions(+), 139 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerInstanceIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Looks like the sweeper file isn't getting copied now |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccSpannerInstanceIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
waiting to review durring iteration. Are you able to build locally successfully ? |
It is, it's just identical to the existing sweeper so it doesn't appear in the diff |
I had no issues building locally. |
🤦🏻 my bad, makes sense! |
Add a custom delete method for UptimeCheckConfigs so 400 errors can warn users to delete their Alert Policies first.
Fixes: hashicorp/terraform-provider-google#10176