-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artifactregistry: implement upstream credentials #9439
Conversation
Hello! I am a robot. It looks like you are a: @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 261 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple changes to suggest
} | ||
} | ||
|
||
resource "google_secret_manager_secret_version" "<%= ctx[:vars]['secret_resource_id'] %>_version" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing with:
Error: Error creating Repository: googleapi: Error 400: An error occurred while validated upstream credentials: Artifact Registry service account "service-01234567890@gcp-sa-artifactregistry.iam.gserviceaccount.com" does not have permission to access the secret version.
You'll need to add this permission as part of the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of how to do this
Line 16 in 5923d4c
resource "google_secret_manager_secret_iam_member" "secret-access" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reference! I tested without secret access permissions and it worked, so I've pushed the changes for testing on github.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 277 insertions(+)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 277 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample|TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
…#9439) * implemented remote auth * add IAM settings to test
…#9439) * implemented remote auth * add IAM settings to test
…#9439) * implemented remote auth * add IAM settings to test
Release Note Template for Downstream PRs (will be copied)