artifactregistry: implement upstream credentials

[Subserial]

Release Note Template for Downstream PRs (will be copied)

artifactregistry: added `remote_repository_config.upstream_credentials` field to `google_artifact_registry_repository` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 261 insertions(+))
Terraform Beta: Diff ( 3 files changed, 261 insertions(+))
TF Conversion: Diff ( 1 file changed, 60 insertions(+))
TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3224
Passed tests 2895
Skipped tests: 328
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[melinath]

A couple changes to suggest

[melinath]

Tests are failing with:

Error: Error creating Repository: googleapi: Error 400: An error occurred while validated upstream credentials: Artifact Registry service account "service-01234567890@gcp-sa-artifactregistry.iam.gserviceaccount.com" does not have permission to access the secret version.

You'll need to add this permission as part of the example

[melinath]

Example of how to do this

magic-modules/mmv1/templates/terraform/examples/cloud_run_service_secret_environment_variables.tf.erb

Line 16 in 5923d4c

resource "google_secret_manager_secret_iam_member" "secret-access" {

[Subserial]

Thanks for the reference! I tested without secret access permissions and it worked, so I've pushed the changes for testing on github.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 277 insertions(+))
Terraform Beta: Diff ( 3 files changed, 277 insertions(+))
TF Conversion: Diff ( 1 file changed, 60 insertions(+))
TF OiCS: Diff ( 4 files changed, 140 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 277 insertions(+))
Terraform Beta: Diff ( 3 files changed, 277 insertions(+))
TF Conversion: Diff ( 1 file changed, 60 insertions(+))
TF OiCS: Diff ( 4 files changed, 140 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3227
Passed tests 2895
Skipped tests: 329
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample|TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCustomExample[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test