Support deleting Firestore databases

[rwhogg]

Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it.

To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running terraform destroy.

This also cleans up some related deletion-related docs and bugs:

• Updates the delete protection docs
• Either delete protection or deletion policy being set prevents destroy

Fixes hashicorp/terraform-provider-google#16488

Fixes hashicorp/terraform-provider-google#16404

Fixes hashicorp/terraform-provider-google#16325

Release Note Template for Downstream PRs (will be copied)

firestore: enabled database deletion upon destroy for `google_firestore_database`

firestore: added virtual field `deletion_policy` to `google_firestore_database`

firestore: prevent destruction if both `deletion_policy` is `DELETE` and `delete_protection_state` is `DELETE_PROTECTION_ENABLED`

---

Manual Testing notes:

delete_protection_state == enabled, policy == abandon, result: abandon
delete_protection_state == enabled, policy == delete, result == prevent
delete_protection_state == disabled, policy == abandon, result == abandon
delete_protection_state == disabled, policy == delete, result == delete

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))

[rxggg]

LGTM!

[modular-magician]

Tests analytics

Total tests: 3224
Passed tests 2892
Skipped tests: 329
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirestoreDatabase_firestoreDatabaseExample|TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirestoreDatabase_firestoreDatabaseExample[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFirestoreDatabase_firestoreDefaultDatabaseExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rwhogg]

@slevenick would it be possible to delete the (default) database associated with the CI project? I can work with you next week to do that if necessary.

The ironic thing is that because database deletion is only possible now, the database from past CI runs is still lingering in the project, and we can't delete it via Terraform until this PR gets in.

[slevenick]

@slevenick would it be possible to delete the (default) database associated with the CI project? I can work with you next week to do that if necessary.

The ironic thing is that because database deletion is only possible now, the database from past CI runs is still lingering in the project, and we can't delete it via Terraform until this PR gets in.

The database should be deleted now

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2893
Skipped tests: 329
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirestoreDatabase_firestoreDefaultDatabaseExample|TestAccMemcacheInstance_update|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2895
Skipped tests: 329
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirestoreDatabase_firestoreDefaultDatabaseExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirestoreDatabase_firestoreDefaultDatabaseExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rwhogg]

@slevenick thanks a bunch for deleting the database, it works now!

[rwhogg]

@slevenick this is ready for review

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 3 files changed, 165 insertions(+), 167 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3237
Passed tests 2905
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccFolderIamPolicy_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test