-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CloudBuild] Add npmPackages, pythonPackages, mavenArtifacts #9460
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 426 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudbuild_trigger" "primary" {
build {
artifacts {
maven_artifacts {
artifact_id = # value needed
group_id = # value needed
path = # value needed
repository = # value needed
version = # value needed
}
npm_packages {
package_path = # value needed
repository = # value needed
}
python_packages {
paths = # value needed
repository = # value needed
}
}
}
}
|
Tests analyticsTotal tests:
|
Can you please add the missing tests for the new added fields? Please see the Missing test report |
Please check, I've added these fields to |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 462 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudbuild_trigger" "primary" {
build {
artifacts {
maven_artifacts {
artifact_id = # value needed
group_id = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 462 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudBuildTrigger_cloudbuildTriggerBuildExample |
Rerun these tests in REPLAYING mode to catch issues
|
I modified the release note. For the guidelines of release note, please check https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
…loudPlatform#9460) * feat(cloudbuild): npmPackages,pythonPackages,mavenArtifacts * test: npmPackages,pythonPackages,mavenArtifacts * fix: replace camelCase with underscore as delimiter
…loudPlatform#9460) * feat(cloudbuild): npmPackages,pythonPackages,mavenArtifacts * test: npmPackages,pythonPackages,mavenArtifacts * fix: replace camelCase with underscore as delimiter
…loudPlatform#9460) * feat(cloudbuild): npmPackages,pythonPackages,mavenArtifacts * test: npmPackages,pythonPackages,mavenArtifacts * fix: replace camelCase with underscore as delimiter
…loudPlatform#9460) * feat(cloudbuild): npmPackages,pythonPackages,mavenArtifacts * test: npmPackages,pythonPackages,mavenArtifacts * fix: replace camelCase with underscore as delimiter
Release Note Template for Downstream PRs (will be copied)
Add npmPackages, pythonPackages, mavenArtifacts
Example: