[CloudBuild] Add npmPackages, pythonPackages, mavenArtifacts

[michaelact]

Release Note Template for Downstream PRs (will be copied)

Add npmPackages, pythonPackages, mavenArtifacts

Example:

cloudbuild: added fields `build.artifacts.maven_artifacts`, `build.artifacts.npm_packages `, and `build.artifacts.python_packages ` to resource `google_cloudbuild_trigger`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 426 insertions(+))
Terraform Beta: Diff ( 2 files changed, 426 insertions(+))
TF Conversion: Diff ( 1 file changed, 165 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudbuild_trigger (29 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudbuild_trigger" "primary" {
  build {
    artifacts {
      maven_artifacts {
        artifact_id = # value needed
        group_id    = # value needed
        path        = # value needed
        repository  = # value needed
        version     = # value needed
      }
      npm_packages {
        package_path = # value needed
        repository   = # value needed
      }
      python_packages {
        paths      = # value needed
        repository = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2896
Skipped tests: 329
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[zli82016]

Can you please add the missing tests for the new added fields?

Please see the Missing test report

[michaelact]

Can you please add the missing tests for the new added fields?

Please see the Missing test report

Please check, I've added these fields to mmv1/templates/terraform/examples/cloudbuild_trigger_build.tf.erb.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 462 insertions(+))
Terraform Beta: Diff ( 3 files changed, 462 insertions(+))
TF Conversion: Diff ( 1 file changed, 165 insertions(+))
TF OiCS: Diff ( 1 file changed, 18 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudbuild_trigger (29 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudbuild_trigger" "primary" {
  build {
    artifacts {
      maven_artifacts {
        artifact_id = # value needed
        group_id    = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3226
Passed tests 2895
Skipped tests: 329
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 462 insertions(+))
Terraform Beta: Diff ( 3 files changed, 462 insertions(+))
TF Conversion: Diff ( 1 file changed, 165 insertions(+))
TF OiCS: Diff ( 1 file changed, 18 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3229
Passed tests 2899
Skipped tests: 329
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zli82016]

I modified the release note. For the guidelines of release note, please check https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

[zli82016]

LGTM. Thanks.