-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serviceDirectoryRegistrations message to resource google_compute_global_forwarding_rule #9485
Conversation
…_connect_google_apis.tf.erb
Hello! I am a robot. It looks like you are a: @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 153 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_global_forwarding_rule" "primary" {
service_directory_registrations {
service = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample |
Rerun these tests in REPLAYING mode to catch issues
|
…t is not currently applicable for globalForwardingRule
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 127 insertions(+)) |
Tests analyticsTotal tests:
|
…global_forwarding_rule (GoogleCloudPlatform#9485) * Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule * Add service_directory_registration message in example private_service_connect_google_apis.tf.erb * Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
…global_forwarding_rule (GoogleCloudPlatform#9485) * Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule * Add service_directory_registration message in example private_service_connect_google_apis.tf.erb * Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
…global_forwarding_rule (GoogleCloudPlatform#9485) * Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule * Add service_directory_registration message in example private_service_connect_google_apis.tf.erb * Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
Add
serviceDirectoryRegistrations
message to Global Forwarding Rule resource.Fixes hashicorp/terraform-provider-google#9758
Release Note Template for Downstream PRs (will be copied)