Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serviceDirectoryRegistrations message to resource google_compute_global_forwarding_rule #9485

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

arnabadg-google
Copy link
Contributor

@arnabadg-google arnabadg-google commented Nov 16, 2023

Add serviceDirectoryRegistrations message to Global Forwarding Rule resource.
Fixes hashicorp/terraform-provider-google#9758

Release Note Template for Downstream PRs (will be copied)

compute: added field `service_directory_registrations` to resource `google_compute_global_forwarding_rule` 

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 153 insertions(+))
Terraform Beta: Diff ( 3 files changed, 157 insertions(+))
TF Conversion: Diff ( 1 file changed, 54 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_global_forwarding_rule (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_global_forwarding_rule" "primary" {
  service_directory_registrations {
    service = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3232
Passed tests 2901
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@arnabadg-google arnabadg-google marked this pull request as ready for review November 17, 2023 19:30
…t is not currently applicable for globalForwardingRule
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 127 insertions(+))
Terraform Beta: Diff ( 3 files changed, 131 insertions(+))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3237
Passed tests 2907
Skipped tests: 330
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@slevenick slevenick merged commit 087da54 into GoogleCloudPlatform:main Nov 21, 2023
14 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
…global_forwarding_rule (GoogleCloudPlatform#9485)

* Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule

* Add service_directory_registration message in example private_service_connect_google_apis.tf.erb

* Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
…global_forwarding_rule (GoogleCloudPlatform#9485)

* Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule

* Add service_directory_registration message in example private_service_connect_google_apis.tf.erb

* Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
…global_forwarding_rule (GoogleCloudPlatform#9485)

* Add serviceDirectoryRegistrations in google_compute_global_forwarding_rule

* Add service_directory_registration message in example private_service_connect_google_apis.tf.erb

* Remove service field from service_directory_registration message as it is not currently applicable for globalForwardingRule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants