feat(vertexai): Support google_vertex_ai_deployment_resource_pool

[shotarok]

Fixes hashicorp/terraform-provider-google#16561

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_deployment_resource_pool`

I confirmed TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample succeeded without errors by running the test on a local machine.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[shotarok]

[QUESTION] Should I add a manually written test for importing a resource by specifying ImportId:?

[rileykarson]

Ah, the import format we're creating is wrong- it assumes that /{{name}} is appended to the base_url. If we add an identity entry similar to

magic-modules/mmv1/products/storage/BucketAccessControl.yaml

Lines 42 to 43 in ce2d84b

	identity:
	- entity

, this should generate import formats that are correct & compatible with the resource id (which is used as the import key)

For this resource that value'll be deploymentResourcePoolId

[shotarok]

Thank you for your comment! I updated the code to use name as identifier along with the custom encoder in 99bb911. So skip_import_test and identity became unnecessary in the end.

[shotarok]

[MEMO] The get returns DeploymentResourcePool, but create requires a wrapper of DeploymentResourcePool.

• https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.deploymentResourcePools/get
• https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.deploymentResourcePools/create

[rileykarson]

Instead of flatten_object can we use an encoder? Very similar to something like https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/encoders/wrap_object_with_template_id.go.erb

(We likely need to remove deploymentResourcePoolId from obj and reinsert it to obj, I think that that encoder's resourceId field was url_param_only)

[shotarok]

Thank you for your feedback. I updated the code to use the custom encoder in 99bb911.

[shotarok]

@rileykarson Hello 👋 Could you approve the cloud build jobs to run acceptance tests?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1146 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1146 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 239 insertions(+))
TF OiCS: Diff ( 4 files changed, 120 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3238
Passed tests 2905
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rileykarson]

Ah, the import format we're creating is wrong- it assumes that /{{name}} is appended to the base_url. If we add an identity entry similar to

magic-modules/mmv1/products/storage/BucketAccessControl.yaml

Lines 42 to 43 in ce2d84b

	identity:
	- entity

, this should generate import formats that are correct & compatible with the resource id (which is used as the import key)

For this resource that value'll be deploymentResourcePoolId

[rileykarson]

Instead of flatten_object can we use an encoder? Very similar to something like https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/encoders/wrap_object_with_template_id.go.erb

(We likely need to remove deploymentResourcePoolId from obj and reinsert it to obj, I think that that encoder's resourceId field was url_param_only)

[rileykarson]

We'll want to define vars and supply the name through that- that will ensure that we add a random suffix and a sweeper prefix to test resources so that we don't leak resources or fail tests due to leaked resources.

Docs: https://googlecloudplatform.github.io/magic-modules/develop/test/#add-a-create-test

[shotarok]

I updated the code to use the random suffix through vars in 99bb911.

[shotarok]

@rileykarson Hello 👋 Sorry for the late response. I updated the code based on your feedback. According to the API doc, all fields are immutable. Therefore, I didn't add a hand-written test for updatable fields. Please let me know if you have a concern. Thanks!

[shotarok]

@rileykarson Happy New Year 👋 When you have time, could you review this PR? Thanks

[shotarok]

@rileykarson Hello 👋 When you have time, could you review this PR? Thanks!

[shotarok]

@rileykarson Hello 👋 If this PR looks good, could you approve the cloud build job? Thanks

[rileykarson]

Sorry about the delay! Losing against my email 😅

Running build

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1106 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1106 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 215 insertions(+))
TF OiCS: Diff ( 4 files changed, 120 insertions(+))

[modular-magician]

Tests analytics

Total tests: 46
Passed tests 45
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIDeploymentResourcePool_vertexAiDeploymentResourcePoolExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shotarok]

@rileykarson Hello 👋 When you have time, could you review the code? Please let me know if merging the latest main branch into this development branch is necessary. Thanks!

[rileykarson]

LGTM, sorry for the delay!