Add Logging Settings datasources.

[zachberger]

Release Note Template for Downstream PRs (will be copied)

`google_logging_organization_settings`

`google_logging_folder_settings`

`google_logging_project_settings`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 454 insertions(+))
Terraform Beta: Diff ( 7 files changed, 454 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3240
Passed tests 2907
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingFolderSettings_datasource|TestAccLoggingProjectSettings_datasource

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingFolderSettings_datasource[Debug log]
TestAccLoggingProjectSettings_datasource[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zachberger]

Any insight to why TestAccLoggingOrganizationSettings_datasource did not run?

[rileykarson]

Good question! I'm not entirely sure- I thought we might have been missing an env var & skipped the test, but that doesn't seem to be the case. @shuyama1 can you tell?

[shuyama1]

Good question! I'm not entirely sure- I thought we might have been missing an env var & skipped the test, but that doesn't seem to be the case. @shuyama1 can you tell?

Looks like it got passed in the replaying mode. I wonder if we run the actual acceptance test instead of in VCR during the replaying mode for this test specifically. I'll need to dig deep into it to find out what happens exactly. Meanwhile, I triggered an independent run for TestAccLoggingOrganizationSettings_datasource on TC and it passed: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleBeta_MmUpstreamTesting_GOOGLEBETA_PACKAGE_LOGGING/64618?buildTab=tests

[rileykarson]

We'll need to add website files as well: https://googlecloudplatform.github.io/magic-modules/develop/add-handwritten-datasource/#add-documentation.

Otherwise, generally looks good- one comment inline.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 454 insertions(+))
Terraform Beta: Diff ( 7 files changed, 454 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3245
Passed tests 2914
Skipped tests: 331
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 637 insertions(+))
Terraform Beta: Diff ( 10 files changed, 637 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3245
Passed tests 2914
Skipped tests: 331
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[zachberger]

Thanks @rileykarson I've fixed up the property and added documentation.

[rileykarson]

LGTM- will merge once the downstreams regenerate from the suggestions I applied.

(if I haven't by EOD feel free to bump / ping)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 637 insertions(+))
Terraform Beta: Diff ( 10 files changed, 637 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3258
Passed tests 2926
Skipped tests: 331
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[zachberger]

I believe this failure is unrelated to my change, however I did experience this same failure in #9384 which I attempted to resolve with 693d184

[rileykarson]

Yeah, that's non-blocking. Confirmed we're not merging a new cassette for that.