-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GKE Hub]: Add Fleet binary authorization config #9545
Conversation
Hello! I am a robot. It looks like you are a: @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 173 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
FYI, in #9389 (review) we accidentally submitted 1 enum field that's not supported yet. Based on go/terraform-releases#schedule, we should have a week before the release is cut so removing that here rather than reverting. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 176 insertions(+), 3 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2Fleet_gkehubFleetBasicExample_update |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 176 insertions(+), 3 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2Fleet_gkehubFleetBasicExample_update |
|
binary_authorization_config { | ||
evaluation_mode = "POLICY_BINDINGS" | ||
policy_bindings = { | ||
name = "projects/${google_project.project.project_id}/platforms/gke/policies/policy_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string doesn't close
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 176 insertions(+), 3 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
mmv1/third_party/terraform/services/gkehub2/resource_gke_hub_fleet_test.go.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 176 insertions(+), 3 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccDataSourceGoogleServiceAccountAccessToken_basic |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 176 insertions(+), 3 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 177 insertions(+), 4 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Any idea why we are getting test failures? Anything I can help with ? |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccLoggingProjectSink_updatePreservesCustomWriter |
Rerun these tests in REPLAYING mode to catch issues
|
@ScottSuarez The errors on my test were due to my own typo in one case and an API enablement flakiness error. I've seen that many times in the last 6 months. It seems to be resolved, but there some flakiness in another test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more ask, can we have a new test where binary_authorization_config
is absent from the terraform code?
What exactly do you want test coverage for? Is adding an additional test step sufficient? So we have:
Running every parameter combination through an E2E test doesn't seem ideal. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccLoggingProjectSink_updatePreservesCustomWriter |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_fleet" "primary" {
default_cluster_config {
binary_authorization_config {
evaluation_mode = # value needed
policy_bindings {
name = # value needed
}
}
}
}
|
I want to ensure that the resource still works without binary_authoritzation_config set on the resource. Since we changed existing tests we not long can guarantee existing deployments by customers continue to work. This is my concern. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Adds binary authorization fields to the default cluster config of the GKEHub resource "Fleet."
b/296461330
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)