-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): support defining autoscaling limit as nodes #9606
feat(spanner): support defining autoscaling limit as nodes #9606
Conversation
…e counts and update example.
…g processing units
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 217 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate|TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/products/spanner/Instance.yaml
Outdated
exactly_one_of: | ||
- max_processing_units | ||
- max_nodes | ||
required_with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing new requirements between existing fields is a breaking change and can only be done in a major release. Can we remove the two required_with
blocks for the existing fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c2thorn Thanks for suggestion, please help take a look again
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccProjectIamPolicy_invalidMembers |
Rerun these tests in REPLAYING mode to catch issues
|
spanner: support defining autoscaling limit using node count
Release Note Template for Downstream PRs (will be copied)