feat(spanner): support defining autoscaling limit as nodes

[rahul2393]

spanner: support defining autoscaling limit using node count

Release Note Template for Downstream PRs (will be copied)

spanner: added support for defining autoscaling limit using node count in `google_spanner_instance`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 2 deletions(-))

[rahul2393]

All test passed!!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 217 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 5 files changed, 217 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3277
Passed tests 2940
Skipped tests: 334
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate|TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate[Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

Introducing new requirements between existing fields is a breaking change and can only be done in a major release. Can we remove the two required_with blocks for the existing fields?

[rahul2393]

@c2thorn Thanks for suggestion, please help take a look again

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 215 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3292
Passed tests 2953
Skipped tests: 338
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test