Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependencies so that google_composer_environment is created after IAM resources in acceptance test #9610

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

SarahFrench
Copy link
Contributor

Relates to (might fix...) hashicorp/terraform-provider-google#15091

Release Note Template for Downstream PRs (will be copied)


…eated after IAM resources in acceptance test
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3275
Passed tests 2941
Skipped tests: 334
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench SarahFrench requested a review from zli82016 December 15, 2023 10:59
@zli82016
Copy link
Member

This PR changes the test TestAccComposerEnvironment_fixPyPiPackages, but this test always passed. I wonder if I miss something.

https://hashicorp.teamcity.com/test/-7930500571679198696?currentProjectId=TerraformProviders_GoogleBeta_NightlyTests&expandTestHistoryChartSection=true

@SarahFrench
Copy link
Contributor Author

@zli82016 you're not missing anything - the last couple of weeks Ive looked at test failures related to missing permissions, and during that work I found that this dependency was missing. This PR started from finding a problem with a tests config instead of starting with a failing test. I linked it to the issue in the PR description because I assumed it was related, but it's not.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the information.

@SarahFrench SarahFrench merged commit fc162b9 into main Dec 18, 2023
7 checks passed
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@SarahFrench SarahFrench deleted the fix-composer-permission-acctest-filures branch February 6, 2024 11:01
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants