-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit dependencies so that google_composer_environment
is created after IAM resources in acceptance test
#9610
Conversation
…eated after IAM resources in acceptance test
Tests analyticsTotal tests:
|
This PR changes the test |
@zli82016 you're not missing anything - the last couple of weeks Ive looked at test failures related to missing permissions, and during that work I found that this dependency was missing. This PR started from finding a problem with a tests config instead of starting with a failing test. I linked it to the issue in the PR description because I assumed it was related, but it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the information.
…eated after IAM resources in acceptance test (GoogleCloudPlatform#9610)
…eated after IAM resources in acceptance test (GoogleCloudPlatform#9610)
…eated after IAM resources in acceptance test (GoogleCloudPlatform#9610)
Relates to (might fix...) hashicorp/terraform-provider-google#15091
Release Note Template for Downstream PRs (will be copied)