-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shielded instance config for Workbench instances #9622
Conversation
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 311 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_workbenchInstanceLabelsExample|TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample|TestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_updateMetadata|TestAccWorkbenchInstance_update |
Rerun these tests in REPLAYING mode to catch issues
|
Will avoid reviewing this since it is in "Draft" mode. Please mark "Ready for Review" when it is ready and @ me here. |
@slevenick has been reviewing Workbench Instances. Might wanna have him be the reviewer here as well. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 380 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_shielded_config_double_apply|TestAccWorkbenchInstance_shielded_config_update|TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample |
|
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
…#9622) * shielded instance config for Workbench instances * Add test to double apply
Closes hashicorp/terraform-provider-google#17002
shielded instance config for Workbench instances
Release Note Template for Downstream PRs (will be copied)