Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shielded instance config for Workbench instances #9622

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Dec 11, 2023

Closes hashicorp/terraform-provider-google#17002

shielded instance config for Workbench instances

Release Note Template for Downstream PRs (will be copied)

workbench: added `shielded_instance_config` field to `google_workbench_instance` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 311 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 311 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 57 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3292
Passed tests 2948
Skipped tests: 337
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_workbenchInstanceLabelsExample|TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample|TestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_updateMetadata|TestAccWorkbenchInstance_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateGpu[Debug log]
TestAccWorkbenchInstance_workbenchInstanceLabelsExample[Debug log]
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample[Debug log]
TestAccWorkbenchInstance_removeGpu[Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]
TestAccWorkbenchInstance_updateMetadata[Debug log]
TestAccWorkbenchInstance_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Dec 12, 2023

Will avoid reviewing this since it is in "Draft" mode. Please mark "Ready for Review" when it is ready and @ me here.

@bcreddy-gcp
Copy link
Contributor Author

@slevenick has been reviewing Workbench Instances. Might wanna have him be the reviewer here as well.

@bcreddy-gcp bcreddy-gcp marked this pull request as ready for review February 14, 2024 01:51
@bcreddy-gcp bcreddy-gcp requested a review from a team as a code owner February 14, 2024 01:51
@rileykarson rileykarson removed the request for review from a team February 14, 2024 18:47
@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 380 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 380 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 57 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 8
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages
  • workbench

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_shielded_config_double_apply|TestAccWorkbenchInstance_shielded_config_update|TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_removeGpu[Debug log]
TestAccWorkbenchInstance_shielded_config_double_apply[Debug log]
TestAccWorkbenchInstance_shielded_config_update[Debug log]
TestAccWorkbenchInstance_update[Debug log]
TestAccWorkbenchInstance_updateGpu[Debug log]
TestAccWorkbenchInstance_updateGpu[Debug log]
TestAccWorkbenchInstance_updateMetadata[Debug log]
TestAccWorkbenchInstance_updateState[Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]
TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@slevenick slevenick merged commit 25d06fe into GoogleCloudPlatform:main Feb 16, 2024
12 of 13 checks passed
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Feb 29, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 6, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Mar 11, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…#9622)

* shielded instance config for Workbench instances

* Add test to double apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gce_setup.shield_instance_config field in the Vertex AI Workbench Instance resource
5 participants