Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing IAM resources dependencies in TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey #9644

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add missing IAM resources dependencies in TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey #9644

merged 1 commit into from
Dec 18, 2023

Conversation

SarahFrench
Copy link
Contributor

Relates to this test failure: hashicorp/terraform-provider-google#16687

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 16 insertions(+))
Terraform Beta: Diff ( 1 file changed, 16 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3293
Passed tests 2956
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench SarahFrench requested a review from trodge December 14, 2023 20:09
@SarahFrench SarahFrench merged commit 0fb627b into main Dec 18, 2023
7 checks passed
This was referenced Dec 18, 2023
Merged
Merged
@SarahFrench SarahFrench mentioned this pull request Dec 18, 2023
Closed
@modular-magician modular-magician mentioned this pull request Dec 18, 2023
Merged
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@SarahFrench @kapreus
Add missing IAM resources dependencies in `TestAccComputeRegionInstan…
9fae3c2 
…ceTemplate_sourceImageEncryptionKey` (GoogleCloudPlatform#9644)
@SarahFrench SarahFrench deleted the add-more-depends_on-to-acctests branch February 6, 2024 11:01
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@SarahFrench @balanaguharsha
Add missing IAM resources dependencies in `TestAccComputeRegionInstan…
688b6df 
…ceTemplate_sourceImageEncryptionKey` (GoogleCloudPlatform#9644)
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@SarahFrench @pengq-google
Add missing IAM resources dependencies in `TestAccComputeRegionInstan…
f7febd3 
…ceTemplate_sourceImageEncryptionKey` (GoogleCloudPlatform#9644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trodge trodge trodge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahFrench @modular-magician @trodge