-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for IAM Group authentication to google_sql_user #9685
add support for IAM Group authentication to google_sql_user #9685
Conversation
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests:
|
Can you please fix the unit test, @pratikgarg10 ? Thanks.
|
mmv1/third_party/terraform/services/sql/resource_sql_user_test.go
Outdated
Show resolved
Hide resolved
The test |
Minor formatting changes
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 83 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
…oudPlatform#9685) * add support for IAM Group authentication to google_sql_user * Update resource_sql_user_test.go Minor formatting changes * Update documentation and minor formatting changes
…oudPlatform#9685) * add support for IAM Group authentication to google_sql_user * Update resource_sql_user_test.go Minor formatting changes * Update documentation and minor formatting changes
…oudPlatform#9685) * add support for IAM Group authentication to google_sql_user * Update resource_sql_user_test.go Minor formatting changes * Update documentation and minor formatting changes
Release Note Template for Downstream PRs (will be copied)