Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for IAM Group authentication to google_sql_user #9685

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

pratikgarg10
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

sql: added support for IAM GROUP authentication in the `type` field of `google_sql_user`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3311
Passed tests 2974
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016
Copy link
Member

zli82016 commented Dec 20, 2023

Can you please fix the unit test, @pratikgarg10 ? Thanks.

gofmt needs running on the following files:
./google-beta/services/sql/resource_sql_user_test.go
You can use the command: `make fmt` to reformat code.
make: *** [GNUmakefile:26: fmtcheck] Error 1
Error: Process completed with exit code 2.

@zli82016
Copy link
Member

Minor formatting changes
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 83 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 83 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3312
Passed tests 2974
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zli82016 zli82016 merged commit 4d160cb into GoogleCloudPlatform:main Dec 20, 2023
12 checks passed
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
…oudPlatform#9685)

* add support for IAM Group authentication to google_sql_user

* Update resource_sql_user_test.go

Minor formatting changes

* Update documentation and minor formatting changes
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…oudPlatform#9685)

* add support for IAM Group authentication to google_sql_user

* Update resource_sql_user_test.go

Minor formatting changes

* Update documentation and minor formatting changes
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…oudPlatform#9685)

* add support for IAM Group authentication to google_sql_user

* Update resource_sql_user_test.go

Minor formatting changes

* Update documentation and minor formatting changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants