Netapp backup vault

[okrause]

Fixes hashicorp/terraform-provider-google#16810

This PR is to support provisioning NetApp Backup Vaults for Google Cloud NetApp Volumes through GCP terraform provider.

Release Note Template for Downstream PRs (will be copied)

google_netapp_backup_vault

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 930 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 930 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 86 insertions(+))
TF OiCS: Diff ( 4 files changed, 109 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3313
Passed tests 2974
Skipped tests: 336
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccNetappbackupVault_netappBackupVaultExample_update|TestAccNetappbackupVault_netappBackupVaultExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccNetappbackupVault_netappBackupVaultExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappbackupVault_netappBackupVaultExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[okrause]

Okay, I just realized that the test harness will run resource_netapp_backup_vault_test.go and resource_netapp_backup_vault_generated_test.go in parallel, with different suffixes. That will not work, as the user is only allowed to create one backup vault per region. Therefore, the test sometimes passed and sometimes fails, due to timing issues. Currently investigating on how to tell the test harness to run the tests sequentially, or will have to use a different region for one of the tests.

[ScottSuarez]

Lets use different regions! :D

[okrause]

Got guidance from @shuyama1. My problem was that generated test and my custom test both created resources in same region and only one resource per region is allowed. Shuya recommended to disable generated test and just use a proper custom test. I disabled generated test and reverted custom test back to use us-central1.

[ScottSuarez]

Some questions and nits.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 862 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 862 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 86 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4
Passed tests 3
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappbackupVault_netappBackupVaultExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappbackupVault_netappBackupVaultExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[ScottSuarez]

Thanks for the work !