-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support vertexai featureonlinestore_featureview GA (standard url) #9696
support vertexai featureonlinestore_featureview GA (standard url) #9696
Conversation
Hello! I am a robot. It looks like you are a: @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
0f3d2da
to
f21e7f4
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample |
Rerun these tests in REPLAYING mode to catch issues
|
f21e7f4
to
2ea27a0
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
937aff4
to
d4b276b
Compare
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample|TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failure is due to reused resource names. Paramaterization will fix it in the long run
mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_featureview.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_featureview.tf.erb
Outdated
Show resolved
Hide resolved
d4b276b
to
76d2d3b
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 1384 insertions(+), 7 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample |
|
@slevenick can you please check and let me know if any other changes are required? Thanks. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample |
Rerun these tests in REPLAYING mode to catch issues
|
...arty/terraform/services/vertexai/resource_vertex_ai_feature_online_store_featureview_test.go
Outdated
Show resolved
Hide resolved
|
||
func testAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_update(context map[string]interface{}) string { | ||
return acctest.Nprintf(` | ||
resource "google_vertex_ai_feature_online_store" "featureonlinestore" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing from here down looks broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran go fmt
again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they continue to be oddly spaced. I don't think go fmt will work on this file as this is a terraform config represented as a string, so the formatter doesn't know how to handle it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. I've ran the terraform formatter separately on the terraform portions and added it back. pls check now.
b2a372d
to
2e90bf5
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated |
Rerun these tests in REPLAYING mode to catch issues
|
|
||
func testAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_update(context map[string]interface{}) string { | ||
return acctest.Nprintf(` | ||
resource "google_vertex_ai_feature_online_store" "featureonlinestore" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they continue to be oddly spaced. I don't think go fmt will work on this file as this is a terraform config represented as a string, so the formatter doesn't know how to handle it
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated |
Rerun these tests in REPLAYING mode to catch issues
|
…ogleCloudPlatform#9696) * support vertexai featureonlinestore_featureview GA * fix pr featureview test failure * fix featureview pr issues * add FeatureView resource with standard base_url * update featureview name * fix spacing in test
…ogleCloudPlatform#9696) * support vertexai featureonlinestore_featureview GA * fix pr featureview test failure * fix featureview pr issues * add FeatureView resource with standard base_url * update featureview name * fix spacing in test
…ogleCloudPlatform#9696) * support vertexai featureonlinestore_featureview GA * fix pr featureview test failure * fix featureview pr issues * add FeatureView resource with standard base_url * update featureview name * fix spacing in test
…ogleCloudPlatform#9696) * support vertexai featureonlinestore_featureview GA * fix pr featureview test failure * fix featureview pr issues * add FeatureView resource with standard base_url * update featureview name * fix spacing in test
Fixed hashicorp/terraform-provider-google#16507
This PR is to support vertexai FeatureOnlineStore.Featureview Resource with Terraform GA provider.
Release Note Template for Downstream PRs (will be copied)