support vertexai featureonlinestore_featureview GA (standard url) #9696

kkram01 · 2023-12-21T08:52:35Z

Fixed hashicorp/terraform-provider-google#16507

This PR is to support vertexai FeatureOnlineStore.Featureview Resource with Terraform GA provider.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_feature_online_store_featureview

modular-magician · 2023-12-21T08:54:11Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-12-21T09:06:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2023-12-21T09:09:37Z

Tests analytics

Total tests: 37
Passed tests 35
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2023-12-21T09:15:02Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-21T09:30:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2023-12-21T09:32:45Z

Tests analytics

Total tests: 37
Passed tests 36
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2023-12-21T09:36:22Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

modular-magician · 2023-12-21T10:37:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1377 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2023-12-21T10:40:39Z

Tests analytics

Total tests: 37
Passed tests 37
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

mmv1/products/vertexai/FeatureOnlineStoreFeatureview.yaml

melinath · 2023-12-22T00:41:16Z

/gcbrun

modular-magician · 2023-12-22T00:52:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2023-12-22T00:55:09Z

Tests analytics

Total tests: 39
Passed tests 37
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2023-12-22T01:00:37Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick

Test failure is due to reused resource names. Paramaterization will fix it in the long run

mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_featureview.tf.erb

modular-magician · 2023-12-22T10:09:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1384 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1384 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2023-12-22T10:12:52Z

Tests analytics

Total tests: 39
Passed tests 38
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2023-12-22T10:15:19Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlinestoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

kkram01 · 2024-01-02T13:40:39Z

@slevenick can you please check and let me know if any other changes are required? Thanks.

mmv1/products/vertexai/FeatureOnlineStoreFeatureview.yaml

modular-magician · 2024-01-03T11:25:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2024-01-03T11:28:33Z

Tests analytics

Total tests: 39
Passed tests 37
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-01-03T11:30:21Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Debug log]
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

...arty/terraform/services/vertexai/resource_vertex_ai_feature_online_store_featureview_test.go

slevenick · 2024-01-05T20:15:29Z

...arty/terraform/services/vertexai/resource_vertex_ai_feature_online_store_featureview_test.go

+
+func testAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_update(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_vertex_ai_feature_online_store" "featureonlinestore" {


Spacing from here down looks broken

Ran go fmt again.

Looks like they continue to be oddly spaced. I don't think go fmt will work on this file as this is a terraform config represented as a string, so the formatter doesn't know how to handle it

Ah ok. I've ran the terraform formatter separately on the terraform portions and added it back. pls check now.

modular-magician · 2024-01-08T09:16:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1374 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2024-01-08T09:20:26Z

Tests analytics

Total tests: 39
Passed tests 38
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-01-08T09:22:03Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

slevenick · 2024-01-08T16:10:42Z

...arty/terraform/services/vertexai/resource_vertex_ai_feature_online_store_featureview_test.go

+
+func testAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_update(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_vertex_ai_feature_online_store" "featureonlinestore" {


Looks like they continue to be oddly spaced. I don't think go fmt will work on this file as this is a terraform config represented as a string, so the formatter doesn't know how to handle it

modular-magician · 2024-01-08T19:31:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1369 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 145 insertions(+))
TF OiCS: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2024-01-08T19:34:15Z

Tests analytics

Total tests: 39
Passed tests 38
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-01-08T19:35:46Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…ogleCloudPlatform#9696) * support vertexai featureonlinestore_featureview GA * fix pr featureview test failure * fix featureview pr issues * add FeatureView resource with standard base_url * update featureview name * fix spacing in test

kkram01 added 3 commits December 20, 2023 16:48

support vertexai featureonlinestore_featureview GA

5b3634d

fix pr featureview test failure

f9aa97f

fix featureview pr issues

2b8ddf7

modular-magician requested a review from roaks3 December 21, 2023 08:54

kkram01 force-pushed the feature/vertexai_featureview1 branch from 0f3d2da to f21e7f4 Compare December 21, 2023 08:55

kkram01 force-pushed the feature/vertexai_featureview1 branch from f21e7f4 to 2ea27a0 Compare December 21, 2023 09:19

kkram01 mentioned this pull request Dec 21, 2023

support vertexai featureonlinestore_featureview GA #9686

Closed

slevenick requested changes Dec 21, 2023

View reviewed changes

kkram01 force-pushed the feature/vertexai_featureview1 branch 2 times, most recently from 937aff4 to d4b276b Compare December 21, 2023 20:22

modular-magician requested a review from slevenick December 22, 2023 00:42

slevenick requested changes Dec 22, 2023

View reviewed changes

mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_featureview.tf.erb Outdated Show resolved Hide resolved

mmv1/templates/terraform/examples/vertex_ai_featureonlinestore_featureview.tf.erb Outdated Show resolved Hide resolved

kkram01 force-pushed the feature/vertexai_featureview1 branch from d4b276b to 76d2d3b Compare December 22, 2023 09:57

modular-magician requested a review from slevenick December 22, 2023 09:58

shotarok reviewed Jan 2, 2024

View reviewed changes

mmv1/products/vertexai/FeatureOnlineStoreFeatureview.yaml Outdated Show resolved Hide resolved

shotarok mentioned this pull request Jan 2, 2024

feat(vertexai): Support google_vertex_ai_feature_group_feature #9692

Merged

melinath removed the request for review from roaks3 January 5, 2024 00:49

slevenick requested changes Jan 5, 2024

View reviewed changes

update featureview name

2e90bf5

kkram01 force-pushed the feature/vertexai_featureview1 branch from b2a372d to 2e90bf5 Compare January 8, 2024 09:05

modular-magician requested a review from slevenick January 8, 2024 09:06

slevenick requested changes Jan 8, 2024

View reviewed changes

fix spacing in test

25772d1

modular-magician requested a review from slevenick January 8, 2024 19:21

slevenick approved these changes Jan 8, 2024

View reviewed changes

slevenick merged commit bc2a741 into GoogleCloudPlatform:main Jan 8, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support vertexai featureonlinestore_featureview GA (standard url) #9696

support vertexai featureonlinestore_featureview GA (standard url) #9696

kkram01 commented Dec 21, 2023 •

edited by slevenick

Loading

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

melinath commented Dec 22, 2023

modular-magician commented Dec 22, 2023

modular-magician commented Dec 22, 2023

modular-magician commented Dec 22, 2023

slevenick left a comment

modular-magician commented Dec 22, 2023

modular-magician commented Dec 22, 2023

modular-magician commented Dec 22, 2023

kkram01 commented Jan 2, 2024

modular-magician commented Jan 3, 2024

modular-magician commented Jan 3, 2024

modular-magician commented Jan 3, 2024

slevenick Jan 5, 2024

kkram01 Jan 8, 2024

slevenick Jan 8, 2024

kkram01 Jan 8, 2024

modular-magician commented Jan 8, 2024

modular-magician commented Jan 8, 2024

modular-magician commented Jan 8, 2024

slevenick Jan 8, 2024

modular-magician commented Jan 8, 2024

modular-magician commented Jan 8, 2024

modular-magician commented Jan 8, 2024

support vertexai featureonlinestore_featureview GA (standard url) #9696

support vertexai featureonlinestore_featureview GA (standard url) #9696

Conversation

kkram01 commented Dec 21, 2023 • edited by slevenick Loading

modular-magician commented Dec 21, 2023

modular-magician commented Dec 21, 2023

Diff report

modular-magician commented Dec 21, 2023

Tests analytics

Action taken

modular-magician commented Dec 21, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 21, 2023

Diff report

modular-magician commented Dec 21, 2023

Tests analytics

Action taken

modular-magician commented Dec 21, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 21, 2023

Diff report

modular-magician commented Dec 21, 2023

Tests analytics

melinath commented Dec 22, 2023

modular-magician commented Dec 22, 2023

Diff report

modular-magician commented Dec 22, 2023

Tests analytics

Action taken

modular-magician commented Dec 22, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 22, 2023

Diff report

modular-magician commented Dec 22, 2023

Tests analytics

Action taken

modular-magician commented Dec 22, 2023

kkram01 commented Jan 2, 2024

modular-magician commented Jan 3, 2024

Diff report

modular-magician commented Jan 3, 2024

Tests analytics

Action taken

modular-magician commented Jan 3, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick Jan 5, 2024

Choose a reason for hiding this comment

kkram01 Jan 8, 2024

Choose a reason for hiding this comment

slevenick Jan 8, 2024

Choose a reason for hiding this comment

kkram01 Jan 8, 2024

Choose a reason for hiding this comment

modular-magician commented Jan 8, 2024

Diff report

modular-magician commented Jan 8, 2024

Tests analytics

Action taken

modular-magician commented Jan 8, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick Jan 8, 2024

Choose a reason for hiding this comment

modular-magician commented Jan 8, 2024

Diff report

modular-magician commented Jan 8, 2024

Tests analytics

Action taken

modular-magician commented Jan 8, 2024

Rerun these tests in REPLAYING mode to catch issues

kkram01 commented Dec 21, 2023 •

edited by slevenick

Loading