-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call #9727
Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call #9727
Conversation
Hello! I am a robot. It looks like you are a: @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 33 insertions(+), 1 deletion(-)) |
To reviewer: an alternative argument name could be |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceAccount_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/resourcemanager/resource_google_service_account.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/resourcemanager/resource_google_service_account_test.go
Show resolved
Hide resolved
ef8f219
to
69c84c6
Compare
mmv1/third_party/terraform/services/resourcemanager/resource_google_service_account_test.go
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 65 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
69c84c6
to
456cf0c
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 75 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
456cf0c
to
321ccc2
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
321ccc2
to
d53e888
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
Hmm I'm a bit stuck on the build error. When I clicked in the build log, it only has one line:
Locally, I followed https://googlecloudplatform.github.io/magic-modules/get-started/generate-providers/ to set up the environment. Then with my change in magic-modules, I ran It showed a lot of It also updated many other products even when I specified PRODUCT and RESOURCE filter. But most importantly, it didn't update the files I edited in magic-modules:
@rileykarson appreciate your help here. |
d53e888
to
312dd6d
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 76 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceAccount_createIgnoreAlreadyExists |
|
312dd6d
to
d803a80
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 78 insertions(+), 7 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceAccount_createIgnoreAlreadyExists |
|
d803a80
to
1fc10be
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 80 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceAccount_createIgnoreAlreadyExists |
Rerun these tests in REPLAYING mode to catch issues
|
Tests are fixed. |
GoogleCloudPlatform#9727) * Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call * Use a separate unit test for create_ignore_already_exists
GoogleCloudPlatform#9727) * Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call * Use a separate unit test for create_ignore_already_exists
GoogleCloudPlatform#9727) * Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call * Use a separate unit test for create_ignore_already_exists
GoogleCloudPlatform#9727) * Add error handling for ALREADY_EXISTS in IAM CreateServiceAccount call * Use a separate unit test for create_ignore_already_exists
Introduce an optional resource argument to Google Cloud IAM Service Account. If
ignore_create_already_exists
is set to true, resource creation would succeed if response error is 409 ALREADY_EXISTS.Fixes hashicorp/terraform-provider-google#16185
Fixes hashicorp/terraform-provider-google#10193
Release Note Template for Downstream PRs (will be copied)