-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to update google_compute_instance resource_manager_tags in place #9740
Allow users to update google_compute_instance resource_manager_tags in place #9740
Conversation
Hello! I am a robot. It looks like you are a: @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 99 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_resourceManagerTags |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 100 insertions(+), 9 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstance_resourceManagerTags |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/compute/resource_compute_instance_test.go.erb
Show resolved
Hide resolved
…n place (GoogleCloudPlatform#9740) * Initial commit * Fixes --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…n place (GoogleCloudPlatform#9740) * Initial commit * Fixes --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…n place (GoogleCloudPlatform#9740) * Initial commit * Fixes --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…n place (GoogleCloudPlatform#9740) * Initial commit * Fixes --------- Co-authored-by: Luca Prete <lucaprete@google.com>
Allows users to update in place
resource_manager_tags
ingoogle_compute_instance
.Release Note Template for Downstream PRs (will be copied)