Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to update google_compute_instance resource_manager_tags in place #9740

Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Jan 3, 2024

Allows users to update in place resource_manager_tags in google_compute_instance.

Release Note Template for Downstream PRs (will be copied)

compute: added update support to `params.resource_manager_tags` in `google_compute_instance`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 99 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 99 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 859
Passed tests 793
Skipped tests: 65
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_resourceManagerTags[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 100 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 100 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 859
Passed tests 793
Skipped tests: 65
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_resourceManagerTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_resourceManagerTags[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@slevenick slevenick self-requested a review January 9, 2024 18:15
@slevenick slevenick merged commit 603220f into GoogleCloudPlatform:main Jan 9, 2024
12 checks passed
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
…n place (GoogleCloudPlatform#9740)

* Initial commit

* Fixes

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
…n place (GoogleCloudPlatform#9740)

* Initial commit

* Fixes

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…n place (GoogleCloudPlatform#9740)

* Initial commit

* Fixes

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…n place (GoogleCloudPlatform#9740)

* Initial commit

* Fixes

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants