Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edgecontainer vpnconnection import rule #9764

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

rayccz2
Copy link
Contributor

@rayccz2 rayccz2 commented Jan 5, 2024

Release Note Template for Downstream PRs (will be copied)

edgecontainer: fixed resource import on `google_edgecontainer_vpn_connection`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Contributor

Self link should already be included in the downstream. It's by default included.

Notice, no diffs generated
#9764 (comment)

Any reason you want to include this more explicitly?

@rayccz2
Copy link
Contributor Author

rayccz2 commented Jan 8, 2024

Self link should already be included in the downstream. It's by default included.

Notice, no diffs generated #9764 (comment)

Any reason you want to include this more explicitly?

We got a bug b/314144187 complaining the terraform import is incorrect.
And from hashicorp/terraform-provider-google#16598 the error message state error fetching live state: error importing resource: Import id \"projects/mock-project/locations/us-central1/vpnConnections/edgecontainervpnconnection-j4idl7vcq3lgwjrbhwmq\" doesn't match any of the accepted formats: [^projects/(?P<project>[^/]+)/locations/(?P<location>[^/]+)/vpnConnections$ ^(?P<project>[^/]+)/(?P<location>[^/]+)$ ^(?P<location>[^/]+)$]"
Which looks like get request failed due to the format error?

Do you have any insight how to resolve this?

@ScottSuarez
Copy link
Contributor

This line needs to be deleted

import_format: ["projects/{{project}}/locations/{{location}}/vpnConnections"]

@rayccz2 rayccz2 changed the title Add self link to edgecontainer vpnconnection Remove edgecontainer vpnconnection import rule Jan 9, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • edgecontainer

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@rayccz2
Copy link
Contributor Author

rayccz2 commented Jan 9, 2024

This line needs to be deleted

import_format: ["projects/{{project}}/locations/{{location}}/vpnConnections"]

Done.

@ScottSuarez ScottSuarez merged commit 5ebba22 into GoogleCloudPlatform:main Jan 9, 2024
12 checks passed
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
)

* Add self link to edgecontainer vpnconnection

* Add self link to edgecontainer vpnconnection
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
)

* Add self link to edgecontainer vpnconnection

* Add self link to edgecontainer vpnconnection
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
)

* Add self link to edgecontainer vpnconnection

* Add self link to edgecontainer vpnconnection
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
)

* Add self link to edgecontainer vpnconnection

* Add self link to edgecontainer vpnconnection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants