Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote user_ip_request_headers field on google_compute_security_policy resource to GA #9872

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

SarahFrench
Copy link
Collaborator

This PR promotes the user_ip_request_headers field on google_compute_security_policy resource to GA.
The API docs show userIpRequestHeaders as present in the GA version of the API.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `user_ip_request_headers` field on `google_compute_security_policy` resource to GA

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 867
Passed tests 803
Skipped tests: 64
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench
Copy link
Collaborator Author

Confusing problem with the checks - I'll retry - /gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 92 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

@SarahFrench
Copy link
Collaborator Author

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 867
Passed tests 803
Skipped tests: 64
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 123 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 867
Passed tests 803
Skipped tests: 64
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench SarahFrench marked this pull request as ready for review January 24, 2024 18:51
@SarahFrench
Copy link
Collaborator Author

@BBBmau requesting you as reviewer for some practice as part of onboarding! 😁

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR matches the steps to follow when promoting a field to GA

LGTM!

@SarahFrench
Copy link
Collaborator Author

/gcbrun

Just re-testing this as I forgot to merge!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 123 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 885
Passed tests 812
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@SarahFrench SarahFrench merged commit 379d462 into main Feb 13, 2024
12 checks passed
@SarahFrench SarahFrench deleted the promote-user_ip_request_headers-to-ga branch February 13, 2024 21:19
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants