-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote user_ip_request_headers
field on google_compute_security_policy
resource to GA
#9872
Conversation
Tests analyticsTotal tests: Click here to see the affected service packages
|
Confusing problem with the checks - I'll retry - /gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 92 insertions(+), 9 deletions(-)) |
I've run the |
Tests analyticsTotal tests: Click here to see the affected service packages
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 123 insertions(+), 9 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
@BBBmau requesting you as reviewer for some practice as part of onboarding! 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR matches the steps to follow when promoting a field to GA
LGTM!
/gcbrun Just re-testing this as I forgot to merge! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 123 insertions(+), 9 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
…olicy` resource to GA (GoogleCloudPlatform#9872)
…olicy` resource to GA (GoogleCloudPlatform#9872)
…olicy` resource to GA (GoogleCloudPlatform#9872)
…olicy` resource to GA (GoogleCloudPlatform#9872)
This PR promotes the
user_ip_request_headers
field ongoogle_compute_security_policy
resource to GA.The API docs show userIpRequestHeaders as present in the GA version of the API.
Release Note Template for Downstream PRs (will be copied)