Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vcenter_network to be set #9946

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Allow vcenter_network to be set #9946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b11037
Allow vcenter_network to be set
naitianliu-google Feb 7, 2024
f85a143
set default from api
naitianliu-google Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mmv1/products/gkeonprem/VmwareCluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ properties:
description:
vcenter_network specifies vCenter network name. Inherited from the
admin cluster.
output: true
immutable: true
naitianliu-google marked this conversation as resolved.
Show resolved Hide resolved
default_from_api: true
- !ruby/object:Api::Type::NestedObject
name: 'hostConfig'
description:
Expand Down
1 change: 1 addition & 0 deletions mmv1/templates/terraform/examples/gkeonprem_vmware_cluster_f5lb.tf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ resource "google_gkeonprem_vmware_cluster" "<%= ctx[:primary_resource_id] %>" {
gateway="test-gateway"
}
}
vcenter_network = "test-vcenter-network"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this field actually set the network or is this just passing the value? as I don't think network test-vcenter-network exists in our project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. This is just passing the value, the test would not actually set the network. @shuyama1

}
control_plane_node {
cpus = 4
Expand Down