Add region disk support to attached disk #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I didn't have to change the import statement after all because Read currently just iterates through a list of disks that are already attached to an instance and each disk is only referenced by |
danawillow
reviewed
Dec 6, 2018
third_party/terraform/resources/resource_compute_attached_disk.go
Outdated
Show resolved
Hide resolved
chrisst
force-pushed
the
issue-2441-region-attached-disks
branch
from
6226d2b to
0614406
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 00a7be8) have been included in your existing downstream PRs. |
danawillow
approved these changes
Dec 7, 2018
modular-magician
force-pushed
the
issue-2441-region-attached-disks
branch
from
0614406 to
7c76090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[all]
Add region disk support to attached disk
[terraform]
[terraform-beta]
[ansible]
[inspec]