Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixtral recipe reg tests on a3ultra #511

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add mixtral recipe reg tests on a3ultra #511

wants to merge 8 commits into from

Conversation

gunjanj007
Copy link
Collaborator

@gunjanj007 gunjanj007 commented Dec 18, 2024

Description

This code

  1. Adds an a3ultra worload
  2. makes functions more generalizable and robust.

Tests

Test composer envs

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@polydier1 polydier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused comments?

@gunjanj007 gunjanj007 changed the title Make code more generalized and robust Add mixtral recipe reg tests on a3ultra Dec 20, 2024
Copy link
Collaborator

@polydier1 polydier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, everything else looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants