feat: add minimum wrapper for compute LRO method (#618)

GoogleCloudPlatform · Nov 21, 2022 · 864bb21 · 864bb21
1 parent 50620e7
commit 864bb21
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/compute/createInstance.js b/compute/createInstance.js
@@ -60,7 +60,7 @@ function main(
 
     console.log(`Creating the ${instanceName} instance in ${zone}...`);
 
-    let [operation] = await instancesClient.insert({
+    const [response] = await instancesClient.insert({
       instanceResource: {
         name: instanceName,
         disks: [
@@ -86,7 +86,7 @@ function main(
       project: projectId,
       zone,
     });
-
+    let operation = response.latestResponse;
     const operationsClient = new compute.ZoneOperationsClient();
 
     // Wait for the create operation to complete.

diff --git a/compute/deleteInstance.js b/compute/deleteInstance.js
@@ -36,12 +36,12 @@ function main(projectId, zone, instanceName) {
 
     console.log(`Deleting ${instanceName} from ${zone}...`);
 
-    let [operation] = await instancesClient.delete({
+    const [response] = await instancesClient.delete({
       project: projectId,
       zone,
       instance: instanceName,
     });
-
+    let operation = response.latestResponse;
     const operationsClient = new compute.ZoneOperationsClient();
 
     // Wait for the delete operation to complete.

diff --git a/compute/package.json b/compute/package.json
@@ -14,7 +14,7 @@
     "test": "mocha test --timeout 1200000"
   },
   "dependencies": {
-    "@google-cloud/compute": "^3.0.0",
+    "@google-cloud/compute": "^3.0.0-alpha.4",
     "@sendgrid/mail": "^7.0.0",
     "nodemailer": "^6.0.0",
     "nodemailer-smtp-transport": "^2.7.4"

diff --git a/compute/test/samples.test.js b/compute/test/samples.test.js
@@ -69,13 +69,13 @@ describe('samples', () => {
 
     execSync(`node createInstance ${projectId} ${zone} ${newinstanceName}`);
 
-    const [operation] = await instancesClient.delete({
+    const [response] = await instancesClient.delete({
       project: projectId,
       zone,
       instance: newinstanceName,
     });
 
-    const operationString = JSON.stringify(operation);
+    const operationString = JSON.stringify(response.latestResponse);
 
     const output = execSync(
       `node waitForOperation ${projectId} '${operationString}'`