functions/slack: config.json -> env vars (#1751)

**Do not merge** until @labtopia updates the docs accordingly.
GoogleCloudPlatform · Apr 28, 2020 · da03d9b · da03d9b
1 parent fab87f8
commit da03d9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/functions/slack/index.js b/functions/slack/index.js
@@ -15,7 +15,6 @@
 'use strict';
 
 // [START functions_slack_setup]
-const config = require('./config.json');
 const {google} = require('googleapis');
 const {verifyRequestSignature} = require('@slack/events-api');
 
@@ -94,7 +93,7 @@ const formatSlackMessage = (query, response) => {
  */
 const verifyWebhook = (req) => {
   const signature = {
-    signingSecret: config.SLACK_SECRET,
+    signingSecret: process.env.SLACK_SECRET,
     requestSignature: req.headers['x-slack-signature'],
     requestTimestamp: req.headers['x-slack-request-timestamp'],
     body: req.rawBody,
@@ -118,7 +117,7 @@ const makeSearchRequest = (query) => {
   return new Promise((resolve, reject) => {
     kgsearch.entities.search(
       {
-        auth: config.KG_API_KEY,
+        auth: process.env.KG_API_KEY,
         query: query,
         limit: 1,
       },

diff --git a/functions/slack/test/index.test.js b/functions/slack/test/index.test.js
@@ -43,7 +43,7 @@ const getSample = () => {
   return {
     program: proxyquire('../', {
       googleapis: {google: googleapis},
-      './config.json': config,
+      process: { env: config },
       '@slack/events-api': eventsApi,
     }),
     mocks: {