Remove repo-tools from appengine/hello-world/flex (#1432)

GoogleCloudPlatform · Jul 26, 2019 · f54a37d · f54a37d
1 parent a7823cf
commit f54a37d
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 17 deletions.
diff --git a/appengine/hello-world/flexible/README.md b/appengine/hello-world/flexible/README.md
@@ -26,7 +26,7 @@ Before you can run or deploy the sample, you need to do the following:
 
 ## Deploying to App Engine
 
-    npm run deploy
+    gcloud app deploy
 
 ## Running the tests
 

diff --git a/appengine/hello-world/flexible/app.js b/appengine/hello-world/flexible/app.js
@@ -34,3 +34,5 @@ app.listen(PORT, () => {
   console.log('Press Ctrl+C to quit.');
 });
 // [END gae_flex_quickstart]
+
+module.exports = app;
diff --git a/appengine/hello-world/flexible/package.json b/appengine/hello-world/flexible/package.json
@@ -13,25 +13,14 @@
     "node": ">=8.0.0"
   },
   "scripts": {
-    "deploy": "gcloud app deploy",
     "start": "node app.js",
-    "system-test": "repo-tools test app",
-    "test": "npm run system-test",
-    "e2e-test": "repo-tools test deploy"
+    "test": "mocha --exit test/*.test.js"
   },
   "dependencies": {
     "express": "^4.16.3"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^3.3.0"
-  },
-  "cloud-repo-tools": {
-    "test": {
-      "app": {
-        "msg": "Hello, world!"
-      }
-    },
-    "requiresKeyFile": true,
-    "requiresProjectId": true
+    "mocha": "^6.2.0",
+    "supertest": "^4.0.2"
   }
 }
diff --git a/appengine/hello-world/flexible/test/app.test.js b/appengine/hello-world/flexible/test/app.test.js
@@ -0,0 +1,16 @@
+const app = require('../app');
+
+const request = require('supertest');
+
+describe('GET /', () => {
+  it('should get 200', done => {
+    request(app)
+      .get('/')
+      .expect(200, done);
+  }),
+    it('should get Hello World', done => {
+      request(app)
+        .get('/')
+        .expect('Hello, world!', done);
+    });
+});
diff --git a/appengine/hello-world/standard/package.json b/appengine/hello-world/standard/package.json
@@ -14,8 +14,7 @@
   },
   "scripts": {
     "start": "node app.js",
-    "system-test": "mocha --exit test/*.test.js",
-    "test": "npm run system-test"
+    "test": "mocha --exit test/*.test.js"
   },
   "dependencies": {
     "express": "^4.16.3"