Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist test environment variables #1866

Closed
mesmacosta opened this issue Jun 9, 2020 · 2 comments
Closed

Whitelist test environment variables #1866

mesmacosta opened this issue Jun 9, 2020 · 2 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@mesmacosta
Copy link
Contributor

In the PR #1799 we use two new environment variables GCLOUD_ORGANIZATION_PROJECT and GCLOUD_ORGANIZATION:

# This must be different from GCLOUD_PROJECT.
# Since build.sh overrides the value for GCLOUD_PROJECT.
env_vars: {
    key: "GCLOUD_ORGANIZATION_PROJECT"
    value: "project-a"
}

# Set organization used by org scoped samples.
env_vars: {
    key: "GCLOUD_ORGANIZATION"
    value: "1081635000895"
}

Running kokoro, returns the error message:

[07:06:43][ERROR] Found un-allowed variables:

GCLOUD_ORGANIZATION="1081635000895" (No matching key in allowed env vars)
GCLOUD_ORGANIZATION_PROJECT="project-a" (No matching key in allowed env vars)

Not sure where, but we need to whitelist those variables, or please advice the correct way of using them. @fhinkel could you help?

FIY, those variables use the values from #1802.

@fhinkel fhinkel self-assigned this Jun 9, 2020
@fhinkel fhinkel added the type: cleanup An internal cleanup or hygiene concern. label Jun 9, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Jun 9, 2020

Submitted the change internally, should get approved tomorrow.

@fhinkel
Copy link
Contributor

fhinkel commented Jun 10, 2020

Merged. Confirmed that the tests don't have the permissions problem anymore.

@fhinkel fhinkel closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants