Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Data Catalog search sample #1799

Conversation

mesmacosta
Copy link
Contributor

@mesmacosta mesmacosta commented May 13, 2020

Currently we have inline search samples at:
https://cloud.google.com/data-catalog/docs/how-to/search#data-catalog-how-to-search-nodejs

Sending this PR so tech writer can point the samples to the nodejs-docs-samples github.

Need help at setting an environment variable with the test project Org ID at:
.kokoro/datacatalog.cfg
Could one of the reviewers provide the org id?

@mesmacosta mesmacosta requested a review from fhinkel as a code owner May 13, 2020 15:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@mesmacosta
Copy link
Contributor Author

mesmacosta commented May 13, 2020

Hi @fhinkel

Changed to [DO NOT MERGE].

Could you help providing the value for the environment variable - Organization ID for the test Project at:
.kokoro/datacatalog.cfg
?

I didn't find any other samples using the Org ID. This sample contains a use case that needs to run with the Org ID.

@mesmacosta mesmacosta changed the title feat: Create Data Catalog search sample [DO NOT MERGE] feat: Create Data Catalog search sample May 13, 2020
@mesmacosta mesmacosta requested a review from fhinkel May 13, 2020 19:00
@fhinkel fhinkel added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2020
@fhinkel
Copy link
Contributor

fhinkel commented May 18, 2020

As far as I can tell we don't have an org set up.

@mesmacosta
Copy link
Contributor Author

I will remove the org_id sample from this PR then, and keep just the sample that uses the project scope, I will try to find out internaly if there's a way to set up a test org id.

@fhinkel
Copy link
Contributor

fhinkel commented May 18, 2020

@mesmacosta
Copy link
Contributor Author

Thanks! I will test it out.

@mesmacosta mesmacosta changed the title [DO NOT MERGE] feat: Create Data Catalog search sample feat: Create Data Catalog search sample May 18, 2020
@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 18, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 18, 2020
@mesmacosta
Copy link
Contributor Author

mesmacosta commented May 18, 2020

@fhinkel
Are you able to whitelist those environment variables?

GCLOUD_ORGANIZATION="1081635000895" (No matching key in allowed env vars)
GCLOUD_ORGANIZATION_PROJECT="project-a" (No matching key in allowed env vars)

@mesmacosta
Copy link
Contributor Author

ping @fhinkel

@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Jun 10, 2020

Whitelisted those variables.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@fhinkel fhinkel removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants