-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iot gateways beta #1016
iot gateways beta #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits.
iot/beta-features/gateway/README.md
Outdated
|
||
This sample app demonstrates sending a command to a IoT Core Device. | ||
This sample app demonstrates sending telemetry data on behalf of device using | ||
the a Cloud IoT Core gateway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "the a" should be either the or a
iot/beta-features/gateway/README.md
Outdated
|
||
Options: | ||
--projectId, -p The Project ID to use. Defaults to the value of the GCLOUD_PROJECT or GOOGLE_CLOUD_PROJECT | ||
environment variables. [string] | ||
--serviceAccount, -s The path to your service credentials JSON. [string] | ||
--serviceAccount, -s The path to your service credentials JSON. [string] [default: "/Users/class/creds_cloud.json"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the default?
} | ||
|
||
// Listen for error messages on a gateway. | ||
function listenForErrorMessages( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) You can merge this with the other listen method and just have one that subscribes to all topics.
beta-features
folder