Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iot gateways beta #1016

Merged
merged 6 commits into from
Dec 10, 2018
Merged

iot gateways beta #1016

merged 6 commits into from
Dec 10, 2018

Conversation

hongalex
Copy link
Contributor

  • Removed commands from beta-features folder
  • Added Gateway samples + tests

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.


This sample app demonstrates sending a command to a IoT Core Device.
This sample app demonstrates sending telemetry data on behalf of device using
the a Cloud IoT Core gateway.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "the a" should be either the or a


Options:
--projectId, -p The Project ID to use. Defaults to the value of the GCLOUD_PROJECT or GOOGLE_CLOUD_PROJECT
environment variables. [string]
--serviceAccount, -s The path to your service credentials JSON. [string]
--serviceAccount, -s The path to your service credentials JSON. [string] [default: "/Users/class/creds_cloud.json"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the default?

}

// Listen for error messages on a gateway.
function listenForErrorMessages(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) You can merge this with the other listen method and just have one that subscribes to all topics.

@hongalex hongalex merged commit 801f853 into master Dec 10, 2018
@hongalex hongalex deleted the iot-gateways-beta branch December 10, 2018 23:12
telpirion pushed a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants