Update storage trigger samples #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
fhinkel
reviewed
May 11, 2019
fhinkel
reviewed
May 11, 2019
| } | ||
|
|
||
| if (!res.ok) { | ||
| return res.text().then(body => Promise.reject(body)); |
There was a problem hiding this comment.
Could we write this with async/await? In its current form it's hard to read.
added 2 commits
May 13, 2019 12:49
fhinkel
approved these changes
May 14, 2019
This was referenced Mar 16, 2020
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I haven't tested these on GCP, and the local tests are all unit tests.
@fhinkel should I do something more comprehensive?